mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Megha Sharma <mshar...@apple.com>
Subject Re: Review Request 61473: Do not kill non partition aware tasks.
Date Mon, 16 Oct 2017 08:59:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61473/
-----------------------------------------------------------

(Updated Oct. 16, 2017, 8:59 a.m.)


Review request for mesos, James Peach, Vinod Kone, and Jiang Yan Xu.


Bugs: MESOS-7215
    https://issues.apache.org/jira/browse/MESOS-7215


Repository: mesos


Description
-------

Master will not kill the tasks for non-Partition aware frameworks
when an unreachable agent re-registers with the master.
Master used to send a ShutdownFrameworkMessages to the agent
to kill the tasks from non partition aware frameworks including the
ones that are still registered which was problematic because the offer
from this agent could still go to the same framework which could then
launch new tasks. The agent would then receive tasks of the same
framework and ignore them because it thinks the framework is shutting
down. The framework is not shutting down of course, so from the master
and the scheduler’s perspective the task is pending in STAGING forever
until the next agent reregistration, which could happen much later.
This commit fixes the problem by not shutting down the non-partition
aware frameworks on such an agent.


Diffs (updated)
-----

  src/master/http.cpp 42139bec519d36316e324ef921157c49cdf2d043 
  src/master/master.hpp 0ddc98259f64b3921d08f5f4ec81543bb0826378 
  src/master/master.cpp 3603878f02ae3dba82811a4a5770dd21ec790ef6 
  src/tests/partition_tests.cpp 0597bd2afaa60121245e0d43b81ac223257e377a 


Diff: https://reviews.apache.org/r/61473/diff/8/

Changes: https://reviews.apache.org/r/61473/diff/7-8/


Testing
-------

make check


Thanks,

Megha Sharma


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message