mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kapil Arya <ka...@mesosphere.io>
Subject Re: Review Request 62616: Binary packaging for Centos 7.
Date Fri, 13 Oct 2017 18:12:11 GMT


> On Oct. 6, 2017, 2:11 p.m., Benno Evers wrote:
> > support/packaging/common/mesos-master.service
> > Lines 7 (patched)
> > <https://reviews.apache.org/r/62616/diff/2/?file=1837912#file1837912line7>
> >
> >     If this is to be common for all packaging, probably it should be `mesos-master.service.in`
and use `@BINDIR@` instead of `/usr/bin`. (same comment applies for the other files under
`packaging/common/`)

I'm not sure about this. But we can always do it in the second round. I just tried to replicate
what we already had for packages generated by Mesosphere.


> On Oct. 6, 2017, 2:11 p.m., Benno Evers wrote:
> > support/packaging/common/mesos-slave
> > Lines 1 (patched)
> > <https://reviews.apache.org/r/62616/diff/2/?file=1837914#file1837914line1>
> >
> >     Should this be `ZK` instead of `MASTER`? And do we need a check here if mesos
was compiled with support for zookeeper?

I think we are compiling Mesos with ZK support by default.


- Kapil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62616/#review187282
-----------------------------------------------------------


On Oct. 13, 2017, 2:02 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62616/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2017, 2:02 p.m.)
> 
> 
> Review request for mesos, Benno Evers, Till Toenshoff, and Vinod Kone.
> 
> 
> Bugs: MESOS-7982
>     https://issues.apache.org/jira/browse/MESOS-7982
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Binary packaging for Centos 7.
> 
> 
> Diffs
> -----
> 
>   support/packaging/Jenkinsfile PRE-CREATION 
>   support/packaging/centos/build_rpm.sh PRE-CREATION 
>   support/packaging/centos/centos6.dockerfile PRE-CREATION 
>   support/packaging/centos/centos7.dockerfile PRE-CREATION 
>   support/packaging/centos/mesos.spec PRE-CREATION 
>   support/packaging/common/mesos PRE-CREATION 
>   support/packaging/common/mesos-init-wrapper PRE-CREATION 
>   support/packaging/common/mesos-master PRE-CREATION 
>   support/packaging/common/mesos-master.service PRE-CREATION 
>   support/packaging/common/mesos-master.upstart PRE-CREATION 
>   support/packaging/common/mesos-slave PRE-CREATION 
>   support/packaging/common/mesos-slave.service PRE-CREATION 
>   support/packaging/common/mesos-slave.upstart PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62616/diff/3/
> 
> 
> Testing
> -------
> 
> The scripts have been tested on an internal Jenkins CI. A buildjob on ASF Jenkins CI
is available at https://builds.apache.org/job/Mesos/job/Packaging/job/CentosRPMs/.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message