mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kapil Arya <ka...@mesosphere.io>
Subject Re: Review Request 62616: Binary packaging for Centos 7.
Date Fri, 13 Oct 2017 18:12:02 GMT


> On Oct. 3, 2017, 12:54 p.m., James Peach wrote:
> > I accidentally made most of my comments on the CentOS6 spec file, but they apply
to the CentOS7 one too. I'm not sure how tractable it is to use the same spec file for both
platforms, but combining them would be helpful if you can make the RPM conditionals work for
you.
> > 
> > Finally, since I think this is intended to be a general-purpose package, we should
enable all the optional compile-time features to broaden the set of users who can consume
these packages.

Thanks for the tips, James! I have now addressed most of your issues and have added some response
for the others. Please take a look and let me know if we can make it better.


- Kapil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62616/#review186959
-----------------------------------------------------------


On Oct. 13, 2017, 2:02 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62616/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2017, 2:02 p.m.)
> 
> 
> Review request for mesos, Benno Evers, Till Toenshoff, and Vinod Kone.
> 
> 
> Bugs: MESOS-7982
>     https://issues.apache.org/jira/browse/MESOS-7982
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Binary packaging for Centos 7.
> 
> 
> Diffs
> -----
> 
>   support/packaging/Jenkinsfile PRE-CREATION 
>   support/packaging/centos/build_rpm.sh PRE-CREATION 
>   support/packaging/centos/centos6.dockerfile PRE-CREATION 
>   support/packaging/centos/centos7.dockerfile PRE-CREATION 
>   support/packaging/centos/mesos.spec PRE-CREATION 
>   support/packaging/common/mesos PRE-CREATION 
>   support/packaging/common/mesos-init-wrapper PRE-CREATION 
>   support/packaging/common/mesos-master PRE-CREATION 
>   support/packaging/common/mesos-master.service PRE-CREATION 
>   support/packaging/common/mesos-master.upstart PRE-CREATION 
>   support/packaging/common/mesos-slave PRE-CREATION 
>   support/packaging/common/mesos-slave.service PRE-CREATION 
>   support/packaging/common/mesos-slave.upstart PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62616/diff/3/
> 
> 
> Testing
> -------
> 
> The scripts have been tested on an internal Jenkins CI. A buildjob on ASF Jenkins CI
is available at https://builds.apache.org/job/Mesos/job/Packaging/job/CentosRPMs/.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message