mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 62959: Added doc for filesystem isolators.
Date Fri, 13 Oct 2017 18:07:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62959/#review187983
-----------------------------------------------------------




docs/container-volume.md
Line 57 (original), 57 (patched)
<https://reviews.apache.org/r/62959/#comment265028>

    "depends on *the* ..."



docs/isolators/filesystems.md
Lines 8 (patched)
<https://reviews.apache.org/r/62959/#comment265036>

    "The Mesos Containerizer ..."



docs/isolators/filesystems.md
Lines 10 (patched)
<https://reviews.apache.org/r/62959/#comment265037>

    "... for a container's ..."



docs/isolators/filesystems.md
Lines 14 (patched)
<https://reviews.apache.org/r/62959/#comment265030>

    "supports *the* ..."



docs/isolators/filesystems.md
Lines 15 (patched)
<https://reviews.apache.org/r/62959/#comment265029>

    AFAIK these anchors are generated by the Github markdown renderer, but not my Middleman.
Once [r/62980](https://reviews.apache.org/r/62980/) lands you might need to rename the anchors.



docs/isolators/filesystems.md
Lines 22 (patched)
<https://reviews.apache.org/r/62959/#comment265032>

    "... the Mesos Containerizer ..."
    "... one of the filesystem isolators ..."



docs/isolators/filesystems.md
Lines 25 (patched)
<https://reviews.apache.org/r/62959/#comment265031>

    "will default to using the ..."



docs/isolators/filesystems.md
Lines 28 (patched)
<https://reviews.apache.org/r/62959/#comment265034>

    "Filesysem isolation ..."?



docs/isolators/filesystems.md
Lines 30 (patched)
<https://reviews.apache.org/r/62959/#comment265038>

    "... functionality ..."



docs/isolators/filesystems.md
Lines 36 (patched)
<https://reviews.apache.org/r/62959/#comment265040>

    "Filesystem isolation ..." or "The filesystem isolator ..."



docs/isolators/filesystems.md
Lines 47 (patched)
<https://reviews.apache.org/r/62959/#comment265033>

    "Use the ..."



docs/isolators/filesystems.md
Lines 50 (patched)
<https://reviews.apache.org/r/62959/#comment265041>

    "The `filesystem/posix` isolator handles ..."



docs/isolators/filesystems.md
Lines 56 (patched)
<https://reviews.apache.org/r/62959/#comment265035>

    "The ..."
    
    Both here and in the first paragraph of the other sections.



docs/isolators/filesystems.md
Lines 70 (patched)
<https://reviews.apache.org/r/62959/#comment265043>

    "The `filesystem/linux` isolator handles ..."


- James Peach


On Oct. 13, 2017, 12:06 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62959/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2017, 12:06 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Ilya Pronin, and James Peach.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added doc for filesystem isolators.
> 
> 
> Diffs
> -----
> 
>   docs/container-volume.md 359d4b20159ed505e2c0ff23a421be41aaf30698 
>   docs/isolators/filesystems.md PRE-CREATION 
>   docs/mesos-containerizer.md 68ed273786d77054eb7973e8f2804138fa2ffff9 
> 
> 
> Diff: https://reviews.apache.org/r/62959/diff/1/
> 
> 
> Testing
> -------
> 
> verified on github.
> https://github.com/jieyu/mesos/blob/doc/docs/isolators/filesystems.md
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message