mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 62974: Disallowed combining resource providers and CheckpointResourcesMessage.
Date Fri, 13 Oct 2017 17:23:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62974/#review187984
-----------------------------------------------------------



PASS: Mesos patch 62974 was successfully built and tested.

Reviews applied: `['62974']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62974

- Mesos Reviewbot Windows


On Oct. 13, 2017, 1:39 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62974/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2017, 1:39 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jan Schlicht.
> 
> 
> Bugs: MESOS-8058
>     https://issues.apache.org/jira/browse/MESOS-8058
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Offer operations on resource provider resources can require
> asynchronous handling since they can in principal take a long time to
> complete. Additionally, they can fail even after passing validation in
> the master, e.g., due to outside changes to the affected resources.
> For these reasons, resource provider resources require an offer
> operation protocol allowing failures outside of the master and
> communicating these failures to the master.
> 
> Since this feedback can only be provided asynchronously, resource
> provider resources are incompatible with `CheckpointResourcesMessage`
> which by design updates the agent with the master's view of the
> agent's resources, and does not account for asynchronous changes to
> the agent's resources (leading e.g., to incompatible state between
> master and agents).
> 
> This patch makes sure that agents with resource providers do not use
> the 'CheckpointResourcesMessage' protocol. This prevents users from
> running resource provider agents against legacy masters.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp 2e05637ed10a39eb3f4ce953506b1cb5d50caf3c 
> 
> 
> Diff: https://reviews.apache.org/r/62974/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message