mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dmitry Zhuk <dz...@twopensource.com>
Subject Re: Review Request 60467: Fixed race in configureSignal and installCtrlHandler.
Date Fri, 13 Oct 2017 10:47:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60467/
-----------------------------------------------------------

(Updated Oct. 13, 2017, 10:47 a.m.)


Review request for mesos, Alexander Rukletsov, Anand Mazumdar, and Avinash sridharan.


Summary (updated)
-----------------

Fixed race in configureSignal and installCtrlHandler.


Bugs: MESOS-8084
    https://issues.apache.org/jira/browse/MESOS-8084


Repository: mesos


Description (updated)
-------

When multiple agents are spawned in a single process, they attempt to
install signal handler concurrently, causing tests, such as
`ExamplesTest.PersistentVolumeFramework` and
`ExamplesTest.DynamicReservationFramework` randomly fail. This adds
missing synchronization to `configureSignal` and `installCtrlHandler`
to resolve the issue.


Diffs (updated)
-----

  src/slave/posix_signalhandler.hpp 49692b140662280b9e150654c5f336f1b920586f 
  src/slave/windows_ctrlhandler.hpp 145a232bcc8428224ac235864845ab91615ca587 


Diff: https://reviews.apache.org/r/60467/diff/2/

Changes: https://reviews.apache.org/r/60467/diff/1-2/


Testing (updated)
-------

On Linux:
```
make check
while true; do ./mesos-tests.sh  --gtest_filter="ExamplesTest.DynamicReservationFramework:ExamplesTest.PersistentVolumeFramework";
done
```
Had several crashes before the fix and none after.

Don't have access to Windows machine, so can't compile ant test.


Thanks,

Dmitry Zhuk


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message