mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ilya Pronin <ipro...@twopensource.com>
Subject Re: Review Request 62959: Added doc for filesystem isolators.
Date Fri, 13 Oct 2017 00:53:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62959/#review187912
-----------------------------------------------------------


Fix it, then Ship it!




Looks good!


docs/isolators/filesystems.md
Lines 17-20 (patched)
<https://reviews.apache.org/r/62959/#comment264986>

    Maybe worth mentioning that it's even broken on hosts with systemd (https://issues.apache.org/jira/browse/MESOS-6563).



docs/isolators/filesystems.md
Lines 41 (patched)
<https://reviews.apache.org/r/62959/#comment264989>

    The isolator link here and below leads to the same section where it is located.


- Ilya Pronin


On Oct. 12, 2017, 5:06 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62959/
> -----------------------------------------------------------
> 
> (Updated Oct. 12, 2017, 5:06 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Ilya Pronin, and James Peach.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added doc for filesystem isolators.
> 
> 
> Diffs
> -----
> 
>   docs/container-volume.md 359d4b20159ed505e2c0ff23a421be41aaf30698 
>   docs/isolators/filesystems.md PRE-CREATION 
>   docs/mesos-containerizer.md 68ed273786d77054eb7973e8f2804138fa2ffff9 
> 
> 
> Diff: https://reviews.apache.org/r/62959/diff/1/
> 
> 
> Testing
> -------
> 
> verified on github.
> https://github.com/jieyu/mesos/blob/doc/docs/isolators/filesystems.md
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message