mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 62962: Added doc for cgroups/cpu isolator.
Date Fri, 13 Oct 2017 00:40:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62962/#review187910
-----------------------------------------------------------


Fix it, then Ship it!





docs/isolators/cgroups-cpu.md
Lines 26 (patched)
<https://reviews.apache.org/r/62962/#comment264976>

    this is a bit confusing. i would refrash that `this mechanism is always enabled when you
turn on this isolator.`



docs/isolators/cgroups-cpu.md
Lines 42 (patched)
<https://reviews.apache.org/r/62962/#comment264980>

    I would say this is "Effects on application when using CFS Bandwidth Limiting"



docs/isolators/cgroups-cpu.md
Lines 48 (patched)
<https://reviews.apache.org/r/62962/#comment264978>

    that are latency sensitive?


- Jie Yu


On Oct. 13, 2017, 12:31 a.m., Ilya Pronin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62962/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2017, 12:31 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and James Peach.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added doc for cgroups/cpu isolator.
> 
> 
> Diffs
> -----
> 
>   docs/isolators/cgroups-cpu.md PRE-CREATION 
>   docs/mesos-containerizer.md 68ed273786d77054eb7973e8f2804138fa2ffff9 
> 
> 
> Diff: https://reviews.apache.org/r/62962/diff/1/
> 
> 
> Testing
> -------
> 
> Verified on GitHub https://github.com/ipronin/mesos/blob/docathon/docs/isolators/cgroups-cpu.md
> 
> 
> Thanks,
> 
> Ilya Pronin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message