mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 54073: Added Linux Namespaces semantic doc.
Date Fri, 13 Oct 2017 00:30:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54073/#review187906
-----------------------------------------------------------


Fix it, then Ship it!





docs/containerizer-internals.md
Lines 152 (patched)
<https://reviews.apache.org/r/54073/#comment264974>

    I'd remove not supported



docs/containerizer-internals.md
Lines 157-159 (patched)
<https://reviews.apache.org/r/54073/#comment264973>

    This is the current semantics, right? Why TBD and not supported?



docs/containerizer-internals.md
Line 122 (original), 173 (patched)
<https://reviews.apache.org/r/54073/#comment264970>

    Not yours, but can you have a link to the isolator lists that we have under `mesos-containerizer.md`


- Jie Yu


On Oct. 13, 2017, 12:23 a.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54073/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2017, 12:23 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Benjamin Mahler, Artem Harutyunyan, Jie Yu,
Neil Conway, Qian Zhang, and Vinod Kone.
> 
> 
> Bugs: MESOS-6335
>     https://issues.apache.org/jira/browse/MESOS-6335
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds a table showing the current semantics
> that the linux launcher supports namespaces for top
> level and nested container.
> 
> 
> Diffs
> -----
> 
>   docs/containerizer-internals.md 5e4f349fbad4429ab7629d0038445d7950787daa 
> 
> 
> Diff: https://reviews.apache.org/r/54073/diff/4/
> 
> 
> Testing
> -------
> 
> Tested by gist view. Here is the link:
> 
> https://github.com/Gilbert88/mesos/blob/31f7340976cb71951501bd77c5f6b777c20530e0/docs/containerizer-internals.md#linux-namespaces
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message