mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gaston Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 61675: Updated doc for the changes of pid namespace sharing.
Date Thu, 12 Oct 2017 23:21:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61675/#review187891
-----------------------------------------------------------


Fix it, then Ship it!




This is great, thanks!


docs/isolators/namespaces-pid.md
Lines 31 (patched)
<https://reviews.apache.org/r/61675/#comment264933>

    Nit: s/Namespace/namespace/ =)



docs/isolators/namespaces-pid.md
Lines 37 (patched)
<https://reviews.apache.org/r/61675/#comment264934>

    Also a nit: s/top level/top-level/



docs/isolators/namespaces-pid.md
Lines 46 (patched)
<https://reviews.apache.org/r/61675/#comment264937>

    Nit: s/as `true`/to `true`/
         s/top level/top-level/


- Gaston Kleiman


On Oct. 12, 2017, 4:14 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61675/
> -----------------------------------------------------------
> 
> (Updated Oct. 12, 2017, 4:14 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Gaston Kleiman, Greg Mann, Jie Yu, Qian Zhang,
and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated doc for the changes of pid namespace sharing.
> 
> 
> Diffs
> -----
> 
>   docs/isolators/namespaces-pid.md bf4dadceddf862cd90bcc6960e8135314d5a92ec 
> 
> 
> Diff: https://reviews.apache.org/r/61675/diff/2/
> 
> 
> Testing
> -------
> 
> N/A.
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message