mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 62734: Added --markdown and --target-people to post-reviews.py.
Date Wed, 11 Oct 2017 22:29:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62734/#review187712
-----------------------------------------------------------




support/post-reviews.py
Lines 142-144 (original), 142-146 (patched)
<https://reviews.apache.org/r/62734/#comment264759>

    The lack of help text in this argument parsing makes these new arguments basically undiscoverable
:(
    
    https://www.reviewboard.org/docs/rbtools/dev/rbt/commands/post/#rbt-post
    
    In any case, it would be nice to have a `--bugs-closed` flag too, for mass-filling JIRAs.


- Joseph Wu


On Oct. 2, 2017, 11:57 a.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62734/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2017, 11:57 a.m.)
> 
> 
> Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> These options are appropriately forwarded to `rbt` so that you can post
> reviews where the commit messages contain Markdown, and have the target
> people automatically filled out.
> 
> 
> Diffs
> -----
> 
>   support/post-reviews.py 5ecde40553c6b1ace9bfcf27a7268450b8bc2838 
> 
> 
> Diff: https://reviews.apache.org/r/62734/diff/1/
> 
> 
> Testing
> -------
> 
> Used it to post this patch.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message