mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 62740: Fixed using `FindOpenSSL` on Windows.
Date Wed, 11 Oct 2017 21:53:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62740/#review187705
-----------------------------------------------------------


Ship it!




I can make the change below before committing.  And add the corresponding documentation blurb.


3rdparty/CMakeLists.txt
Lines 123-139 (patched)
<https://reviews.apache.org/r/62740/#comment264755>

    As discussed offline, we don't want to forward SSL arguments to projects which do not
use SSL.  As such, this block should append to a new variable `CMAKE_SSL_FORWARD_ARGS`.  Libevent
and cURL would then forward two sets of args.


- Joseph Wu


On Oct. 2, 2017, 4:46 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62740/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2017, 4:46 p.m.)
> 
> 
> Review request for mesos, John Kordich, Joseph Wu, and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Specifically we now forward all possible hints to `FindOpenSSL` to the
> `libevent` and `curl` libraries, as they need to use SSL in the same
> configured manner. Furthermore, we explicitly always set `curl` to
> enable or disable its use of OpenSSL based on our use, as otherwise it
> may detect an OpenSSL installation and cause conflicts (this is the same
> as we already do for `libevent`.
> 
> We also prefer the multi-threaded version of OpenSSL on Windows.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt 4e10631cff801f19b191e18528900087d8177a1e 
>   cmake/CompilationConfigure.cmake a94cfa14e4eeb727b384d76b8edd41ab3eb97833 
> 
> 
> Diff: https://reviews.apache.org/r/62740/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message