mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 62732: Added CMake documentation.
Date Wed, 11 Oct 2017 19:21:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62732/#review187673
-----------------------------------------------------------


Ship it!




Going to make some tweaks (rewording a couple sentences) here and there before committing,
but mostly LGTM.


docs/cmake-examples.md
Lines 36-41 (patched)
<https://reviews.apache.org/r/62732/#comment264733>

    Going to replace this TODO with a link:
    https://cmake.org/cmake/help/latest/module/ExternalProject.html



docs/cmake.md
Lines 76 (patched)
<https://reviews.apache.org/r/62732/#comment264726>

    I'll make these links:
    * https://cmake.org/cmake/help/latest/policy/CMP0012.html
    * https://cmake.org/cmake/help/latest/policy/CMP0054.html



docs/cmake.md
Lines 119 (patched)
<https://reviews.apache.org/r/62732/#comment264728>

    I feel this section deserves to be placed right after installation (and before discussion
of mistakes or style).



docs/cmake.md
Lines 191-196 (patched)
<https://reviews.apache.org/r/62732/#comment264730>

    This could be a numbered list.



docs/cmake.md
Lines 204-210 (patched)
<https://reviews.apache.org/r/62732/#comment264732>

    Going to insert a link to: https://cmake.org/cmake/help/latest/command/link_directories.html


- Joseph Wu


On Oct. 5, 2017, noon, Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62732/
> -----------------------------------------------------------
> 
> (Updated Oct. 5, 2017, noon)
> 
> 
> Review request for mesos, Benjamin Bannier, Jeff Coffler, Greg Mann, John Kordich, James
Peach, Joseph Wu, and Li Li.
> 
> 
> Bugs: MESOS-3107
>     https://issues.apache.org/jira/browse/MESOS-3107
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This adds a CMake documentation file with best practices, CMake By
> Example, and consolidates, fixes, and updates the CMake configuration
> options to the configuration documentation.
> 
> 
> Diffs
> -----
> 
>   docs/cmake-examples.md PRE-CREATION 
>   docs/cmake.md PRE-CREATION 
>   docs/configuration-cmake.md 1b10221429a92eddff5733e1059172b6c190b5f3 
>   docs/configuration.md e1fd9f75179b272c3cae3dd5be5e38f269044df5 
>   docs/home.md f9b35e3e8f9af024a58760c345931d73a83654ff 
> 
> 
> Diff: https://reviews.apache.org/r/62732/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message