mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Till Toenshoff <toensh...@me.com>
Subject Re: Review Request 62592: Added basic HTTP authenticatee implementation.
Date Tue, 10 Oct 2017 18:07:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62592/
-----------------------------------------------------------

(Updated Oct. 10, 2017, 6:07 p.m.)


Review request for mesos, Armand Grillet, Benjamin Bannier, Greg Mann, and Kapil Arya.


Changes
-------

comments.


Bugs: MESOS-8017
    https://issues.apache.org/jira/browse/MESOS-8017


Repository: mesos


Description
-------

Moves the hardcoded basic HTTP authentication code from within the
scheduler library into the modularized HTTP authenticatee interface.


Diffs (updated)
-----

  src/CMakeLists.txt 1a0dff3604c288d2af8ecc23f1ec73f5a350bc31 
  src/Makefile.am da8af916652a80303f37b65056920676726f8dfe 
  src/authentication/http/basic_authenticatee.hpp PRE-CREATION 
  src/authentication/http/basic_authenticatee.cpp PRE-CREATION 
  src/common/http.hpp 0e6b1c59860e75c04e2e3be2520ed2b39c84ac90 


Diff: https://reviews.apache.org/r/62592/diff/5/

Changes: https://reviews.apache.org/r/62592/diff/4-5/


Testing
-------

Integration test in external project. Further tests upcoming.


Thanks,

Till Toenshoff


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message