mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 62594: Updated scheduler library for modularized HTTP authenticatee use.
Date Tue, 10 Oct 2017 05:24:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62594/#review187493
-----------------------------------------------------------


Fix it, then Ship it!





src/scheduler/flags.hpp
Lines 53 (patched)
<https://reviews.apache.org/r/62594/#comment264516>

    I checked a few places in the master flags, and in that file we advise users to load modules
via the `--modules` flag, rather than using the environment variable as you've done here.
Perhaps it would be more consistent to use `--modules` here?


- Greg Mann


On Oct. 2, 2017, 10:29 a.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62594/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2017, 10:29 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Armand Grillet, Benjamin Bannier, Greg Mann,
Kapil Arya, and Vinod Kone.
> 
> 
> Bugs: MESOS-8021
>     https://issues.apache.org/jira/browse/MESOS-8021
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Allows the scheduler library to load an HTTP authenticatee module
> providing custom mechanisms for authentication.
> 
> 
> Diffs
> -----
> 
>   src/scheduler/flags.hpp 1e8efc06b40b17d6fa9d9516a83893485804fc72 
>   src/scheduler/scheduler.cpp 78f53707364ab988bcc53ec2c95490df04cd9a6c 
> 
> 
> Diff: https://reviews.apache.org/r/62594/diff/4/
> 
> 
> Testing
> -------
> 
> Integration test in external project. Further tests upcoming.
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message