mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 62592: Added basic HTTP authenticatee implementation.
Date Sat, 07 Oct 2017 00:46:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62592/#review187320
-----------------------------------------------------------




src/authentication/http/basic_authenticatee.cpp
Lines 87-88 (patched)
<https://reviews.apache.org/r/62592/#comment264232>

    Fits on one line.


- Greg Mann


On Oct. 2, 2017, 10:12 a.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62592/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2017, 10:12 a.m.)
> 
> 
> Review request for mesos, Armand Grillet, Benjamin Bannier, Greg Mann, and Kapil Arya.
> 
> 
> Bugs: MESOS-8017
>     https://issues.apache.org/jira/browse/MESOS-8017
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added basic HTTP authenticatee implementation.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 1a0dff3604c288d2af8ecc23f1ec73f5a350bc31 
>   src/Makefile.am da8af916652a80303f37b65056920676726f8dfe 
>   src/authentication/http/basic_authenticatee.hpp PRE-CREATION 
>   src/authentication/http/basic_authenticatee.cpp PRE-CREATION 
>   src/common/http.hpp 0e6b1c59860e75c04e2e3be2520ed2b39c84ac90 
> 
> 
> Diff: https://reviews.apache.org/r/62592/diff/3/
> 
> 
> Testing
> -------
> 
> Integration test in external project. Further tests upcoming.
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message