mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Re: Review Request 62616: Binary packaging for Centos 7.
Date Fri, 06 Oct 2017 18:11:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62616/#review187282
-----------------------------------------------------------



In general, I would like to +1 Jie's comments, it would be really nice to have the ability
to create a .deb/.rpm package from a local working directory and to have only very minimal
logic in docker, so we don't get into a situation where we effectively depend on docker to
build mesos.


support/packaging/centos/6/Dockerfile
Lines 90 (patched)
<https://reviews.apache.org/r/62616/#comment264208>

    This seems to install much more than just the  `BuildRequires` listed in the spec file
below.



support/packaging/centos/6/Dockerfile
Lines 99 (patched)
<https://reviews.apache.org/r/62616/#comment264209>

    Do we reuse the generated container anywhere? If not, it doesn't seem like ccache could
have any cache hits.
    
    Also, does the yum package automatically set ccache as the default compiler? On debian,
some manual work is still required after installing the package to either set up the appropriate
symlinks or to manually set `CXX="ccache g++"`



support/packaging/common/mesos-master.service
Lines 7 (patched)
<https://reviews.apache.org/r/62616/#comment264205>

    If this is to be common for all packaging, probably it should be `mesos-master.service.in`
and use `@BINDIR@` instead of `/usr/bin`. (same comment applies for the other files under
`packaging/common/`)



support/packaging/common/mesos-slave
Lines 1 (patched)
<https://reviews.apache.org/r/62616/#comment264207>

    Should this be `ZK` instead of `MASTER`? And do we need a check here if mesos was compiled
with support for zookeeper?


- Benno Evers


On Sept. 27, 2017, 9:50 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62616/
> -----------------------------------------------------------
> 
> (Updated Sept. 27, 2017, 9:50 p.m.)
> 
> 
> Review request for mesos, Benno Evers, Till Toenshoff, and Vinod Kone.
> 
> 
> Bugs: MESOS-7982
>     https://issues.apache.org/jira/browse/MESOS-7982
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Binary packaging for Centos 7.
> 
> 
> Diffs
> -----
> 
>   support/packaging/Jenkinsfile PRE-CREATION 
>   support/packaging/centos/6/Dockerfile PRE-CREATION 
>   support/packaging/centos/6/mesos.spec PRE-CREATION 
>   support/packaging/centos/7/Dockerfile PRE-CREATION 
>   support/packaging/centos/7/mesos.spec PRE-CREATION 
>   support/packaging/common/mesos PRE-CREATION 
>   support/packaging/common/mesos-init-wrapper PRE-CREATION 
>   support/packaging/common/mesos-master PRE-CREATION 
>   support/packaging/common/mesos-master.service PRE-CREATION 
>   support/packaging/common/mesos-master.upstart PRE-CREATION 
>   support/packaging/common/mesos-slave PRE-CREATION 
>   support/packaging/common/mesos-slave.service PRE-CREATION 
>   support/packaging/common/mesos-slave.upstart PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62616/diff/2/
> 
> 
> Testing
> -------
> 
> The scripts have been tested on an internal Jenkins CI. A buildjob on ASF Jenkins CI
is available at https://builds.apache.org/job/Mesos/job/Packaging/job/CentosRPMs/.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message