mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 62417: Installed newer cmake version in mesos-tidy Docker image.
Date Fri, 06 Oct 2017 16:08:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62417/#review187275
-----------------------------------------------------------


Fix it, then Ship it!





support/mesos-tidy/Dockerfile
Line 27 (original), 27 (patched)
<https://reviews.apache.org/r/62417/#comment264194>

    Do we want to skip this for now then?



support/mesos-tidy/Dockerfile
Lines 66-67 (patched)
<https://reviews.apache.org/r/62417/#comment264195>

    Do we need either of these steps?
    Can we just do this instead?
    ```
    bash /tmp/install-cmake.sh --skip-license --prefix=/usr/local
    ```


- Michael Park


On Sept. 19, 2017, 1:42 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62417/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2017, 1:42 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> As of '85bc58196fc2bcb94e8e3193dacf5cc8a2af4301' the Mesos cmake setup
> requires at least cmake-3.7.0. This patch install cmake-3.8.2 in the
> mesos-tidy Docker image so we can build Mesos in that image as well.
> 
> 
> Diffs
> -----
> 
>   support/mesos-tidy/Dockerfile 1cf582ece03335c8db92a242c5870f11249a4f26 
> 
> 
> Diff: https://reviews.apache.org/r/62417/diff/1/
> 
> 
> Testing
> -------
> 
> Built and ran the image with a modified `support/mesos-tidy.sh` that does not force-download
the image.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message