mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 62804: Formatted 'synchronized' like loop instead of function.
Date Fri, 06 Oct 2017 15:58:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62804/#review187274
-----------------------------------------------------------


Ship it!




Ship It!

- Michael Park


On Oct. 6, 2017, 1:55 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62804/
> -----------------------------------------------------------
> 
> (Updated Oct. 6, 2017, 1:55 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We typically format 'synchronized' like a loop, i.e., we prefer
> 
>     // Loop-like formatting.
>     synchronized (lock) {
>       // Body.
>     }
> 
> over e.g.,
> 
>     // Function-like formatting.
>     synchronized(lock)
>     {
>       // Body.
>     }
> 
> This patch updates the clang-format configuration to treat
> 'synchronized' blocks like loops instead of functions. This just
> codifies the existing convention in the code, so that this is a NFC.
> 
> 
> Diffs
> -----
> 
>   support/clang-format bb587027a6c5b3660552a654ec06766c3ed0f6fe 
> 
> 
> Diff: https://reviews.apache.org/r/62804/diff/1/
> 
> 
> Testing
> -------
> 
> Confirmed that this formats like advertized.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message