mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <bbann...@apache.org>
Subject Re: Review Request 62638: Removed support for platforms without O_CLOEXEC.
Date Wed, 04 Oct 2017 09:26:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62638/#review187074
-----------------------------------------------------------


Fix it, then Ship it!





3rdparty/stout/include/stout/os/open.hpp
Lines 26 (patched)
<https://reviews.apache.org/r/62638/#comment264021>

    I believe we should update the minimal Linux kernel requirements in the getting started
documentation,  https://github.com/apache/mesos/blob/32ea75b8426fb3972680a397dc3a05ff266d166d/docs/getting-started.md#L27.
    
    With this change we are introducing a hard requirement on kernels >=2.6.23 for even
basic functionality, see https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=f23513e8d96cf5e6cf8d2ff0cb5dd6bbc33995e4,
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=4a19542e5f694cd408a32c3d9dc593ba9366e2d7.


- Benjamin Bannier


On Sept. 28, 2017, 12:20 a.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62638/
> -----------------------------------------------------------
> 
> (Updated Sept. 28, 2017, 12:20 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, and Jie Yu.
> 
> 
> Bugs: MESOS-8027
>     https://issues.apache.org/jira/browse/MESOS-8027
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The `O_CLOEXEC` fallback code was broken since it did not guarantee
> to include `fcntl.h` before checking for the `O_CLOEXEC` symbol.
> O_CLOEXEC is supported by all reasonably current service platforms,
> so we should not need to fall back to compatibility code. So rather
> than fixing the fallback code, we can just eliminate it.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/os/open.hpp c9346c62e01688f0f55811f7acbe63321b084355 
>   3rdparty/stout/include/stout/os/windows/fcntl.hpp ac90bf08ccf5b594e70310e9843475502b3603a5

>   3rdparty/stout/include/stout/windows.hpp 1d865f8fd23aba0198017f0bf4be8471cfb714ed 
> 
> 
> Diff: https://reviews.apache.org/r/62638/diff/3/
> 
> 
> Testing
> -------
> 
> make check (Fedora 26)
> 
> Manually verified that sandbox files opened through the webui get the `O_CLOEXEC` flag
applied.
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message