mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 62655: Made 'UpdateSlaveMessage' a union of possible updates.
Date Tue, 03 Oct 2017 17:32:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62655/#review186982
-----------------------------------------------------------


Fix it, then Ship it!





src/master/master.cpp
Lines 6841-6843 (patched)
<https://reviews.apache.org/r/62655/#comment263934>

    IIUC, this assumes that `total_resources` in the `UpdateSlaveMessage` only contains non
revocable resources? If that's the case, can you add a comment to the message protobuf?


- Jie Yu


On Oct. 2, 2017, 4:53 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62655/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2017, 4:53 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The 'UpdateSlaveMessage' could either transport an update to an
> agent's total, or to its oversubscribed resources. In certain
> scenarios this required the agent to send two messages where before
> one was sufficient. When talking to a master which did not understand
> the 'type' field this would have let the master to rescind all offers
> for revocable resources from that agent.
> 
> This patch changes the message to be a union of possible updates,
> i.e., it is now possible to send updates to both the total and the
> oversubscribed resources simultaneously on agent registration and
> reregistration without the master rescinding offers for revocable
> resources on the agent.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp b40621ee3870b1968ab1b05dd0f41a489f4db00e 
>   src/messages/messages.proto dc4e19c08d671743f08223dcdf1dbc336b3940bd 
>   src/slave/slave.cpp bf85baf8b7f7ebf52afa25214e71278f18dc9b30 
>   src/tests/oversubscription_tests.cpp 02b10d6689dd6f01510cd2d5db2bb76b4b190eca 
> 
> 
> Diff: https://reviews.apache.org/r/62655/diff/3/
> 
> 
> Testing
> -------
> 
> `make check`; also tested as part of https://reviews.apache.org/r/61183/.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message