mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 62648: Added a test for nested container resource limitations.
Date Tue, 03 Oct 2017 17:05:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62648/#review186974
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/default_executor_tests.cpp
Lines 1461-1482 (patched)
<https://reviews.apache.org/r/62648/#comment263923>

    Do you still need this?



src/tests/default_executor_tests.cpp
Lines 1485 (patched)
<https://reviews.apache.org/r/62648/#comment263924>

    I would suggest we just set `container_disk_watch_interval` to be a smaller value


- Jie Yu


On Sept. 28, 2017, 12:19 a.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62648/
> -----------------------------------------------------------
> 
> (Updated Sept. 28, 2017, 12:19 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Bugs: MESOS-7963
>     https://issues.apache.org/jira/browse/MESOS-7963
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a test to verify that resource limitations incurred by a nested
> container are propagated all the way back to the scheduler through a
> `TASK_FAILED` status update.
> 
> 
> Diffs
> -----
> 
>   src/tests/default_executor_tests.cpp dd1a6ad0d4e2bf74972e15b478652196ee9cd927 
> 
> 
> Diff: https://reviews.apache.org/r/62648/diff/1/
> 
> 
> Testing
> -------
> 
> make check (Fedora 26)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message