mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 62616: Binary packaging for Centos 7.
Date Tue, 03 Oct 2017 16:54:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62616/#review186959
-----------------------------------------------------------



I accidentally made most of my comments on the CentOS6 spec file, but they apply to the CentOS7
one too. I'm not sure how tractable it is to use the same spec file for both platforms, but
combining them would be helpful if you can make the RPM conditionals work for you.

Finally, since I think this is intended to be a general-purpose package, we should enable
all the optional compile-time features to broaden the set of users who can consume these packages.


support/packaging/centos/6/mesos.spec
Lines 29 (patched)
<https://reviews.apache.org/r/62616/#comment263886>

    Also:
    ``
    BuildRequires: elfutils-libelf-devel
    BuildRequires: libblkid-devel
    BuildRequires: xfsprogs-devel
    BuildRequires: cuda-minimal-build-8-0
    BuildRequires: kernel-headers
    BuildRequires: patch
    ```



support/packaging/centos/6/mesos.spec
Lines 30 (patched)
<https://reviews.apache.org/r/62616/#comment263889>

    I think you need a JDK version here, and probably Maven too if you want the Java build
to work.



support/packaging/centos/6/mesos.spec
Lines 33 (patched)
<https://reviews.apache.org/r/62616/#comment263897>

    Don't you also need to `BuildRequires` a compiler from devtoolset?



support/packaging/centos/6/mesos.spec
Lines 39 (patched)
<https://reviews.apache.org/r/62616/#comment263899>

    Not sure this is a good idea. The `ntp` or `chrony` packages would be an equally good
choice.



support/packaging/centos/6/mesos.spec
Lines 51 (patched)
<https://reviews.apache.org/r/62616/#comment263890>

    Put one option per line to make future changes more diffable:
    ```
    %configure \ 
    --enable-optimize \
    ...
    ```



support/packaging/centos/6/mesos.spec
Lines 56 (patched)
<https://reviews.apache.org/r/62616/#comment263895>

    ```
    --enable-hardening \
    --enable-port-mapping-isolator \
    --enable-xfs-disk-isolator \
    ```



support/packaging/centos/6/mesos.spec
Lines 57 (patched)
<https://reviews.apache.org/r/62616/#comment263901>

    Enable Python or Java?



support/packaging/centos/7/Dockerfile
Lines 65 (patched)
<https://reviews.apache.org/r/62616/#comment263909>

    Don't install these, use [yum-builddep](https://jsmith.fedorapeople.org/drafts/SMG/html/Software_Management_Guide/ch07s05.html)
to ensure that you have the `BuildDepends` correct.



support/packaging/common/mesos
Lines 2 (patched)
<https://reviews.apache.org/r/62616/#comment263906>

    This seems low. Our busy clusters need at least 16K.



support/packaging/common/mesos-init-wrapper
Lines 5 (patched)
<https://reviews.apache.org/r/62616/#comment263904>

    All the `slaves` should be `agents`, right?


- James Peach


On Sept. 27, 2017, 9:50 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62616/
> -----------------------------------------------------------
> 
> (Updated Sept. 27, 2017, 9:50 p.m.)
> 
> 
> Review request for mesos, Benno Evers, Till Toenshoff, and Vinod Kone.
> 
> 
> Bugs: MESOS-7982
>     https://issues.apache.org/jira/browse/MESOS-7982
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Binary packaging for Centos 7.
> 
> 
> Diffs
> -----
> 
>   support/packaging/Jenkinsfile PRE-CREATION 
>   support/packaging/centos/6/Dockerfile PRE-CREATION 
>   support/packaging/centos/6/mesos.spec PRE-CREATION 
>   support/packaging/centos/7/Dockerfile PRE-CREATION 
>   support/packaging/centos/7/mesos.spec PRE-CREATION 
>   support/packaging/common/mesos PRE-CREATION 
>   support/packaging/common/mesos-init-wrapper PRE-CREATION 
>   support/packaging/common/mesos-master PRE-CREATION 
>   support/packaging/common/mesos-master.service PRE-CREATION 
>   support/packaging/common/mesos-master.upstart PRE-CREATION 
>   support/packaging/common/mesos-slave PRE-CREATION 
>   support/packaging/common/mesos-slave.service PRE-CREATION 
>   support/packaging/common/mesos-slave.upstart PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62616/diff/2/
> 
> 
> Testing
> -------
> 
> The scripts have been tested on an internal Jenkins CI. A buildjob on ASF Jenkins CI
is available at https://builds.apache.org/job/Mesos/job/Packaging/job/CentosRPMs/.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message