mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 62511: Fixed OpenSSL support in libprocess for Windows.
Date Mon, 02 Oct 2017 23:48:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62511/
-----------------------------------------------------------

(Updated Oct. 2, 2017, 4:48 p.m.)


Review request for mesos, John Kordich, Joseph Wu, and Till Toenshoff.


Changes
-------

Used localized typedef instead of pre-processor definition.


Bugs: MESOS-7992
    https://issues.apache.org/jira/browse/MESOS-7992


Repository: mesos


Description
-------

This patch adds support for building with OpenSSL on Windows. This
requires an installation of OpenSSL, such as 1.0.2L from Shining Light
Productions. Mesos must be configured like:

    -DENABLE_LIBEVENT=ON -DENABLE_SSL=ON
    -DOPENSSL_ROOT_DIR="C:\OpenSSL-Win64"

The use of `_POSIX_HOST_NAME_MAX` was replaced with `MAXHOSTNAMELEN`,
consistent with the rest of libprocess.

Windows does not define `in_addr_t`, but the type as declared by our
cURL dependency for Windows is `unsigned long`.

OpenSSL on Windows requires the adapater module `openssl/applink.c` to
be compiled as part of the consuming project to deal with Windows
runtime library differences. Not doing so manifests itself as the "no
OPENSSL_Applink" runtime error. The OpenSSL FAQ recommends simply
`#include`-ing it in one of the project's source files, e.g.
libprocess's `ssl/utilities.cpp`.


Diffs (updated)
-----

  3rdparty/libprocess/include/process/ssl/utilities.hpp 797353ce36e805d72959b3f394d3e1d11e2cd89b

  3rdparty/libprocess/src/openssl.hpp e74db5f52b8a7d944317de15eadde277aee85e06 
  3rdparty/libprocess/src/openssl.cpp d16cc1d092518a5adbde840683168f3c79e5f07b 
  3rdparty/libprocess/src/ssl/utilities.cpp d752acb8af734f8f918dba6ba4fccc2802c81ec5 


Diff: https://reviews.apache.org/r/62511/diff/2/

Changes: https://reviews.apache.org/r/62511/diff/1-2/


Testing
-------


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message