mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 62735: Disable on Windows new tests that use file URIs.
Date Mon, 02 Oct 2017 23:45:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62735/#review186916
-----------------------------------------------------------


Ship it!




I'm going to rephrase the description a bit to reflect the actual problem (that we'll eventually
fix in MESOS-6705).  See below.


src/tests/default_executor_tests.cpp
Lines 1378-1379 (patched)
<https://reviews.apache.org/r/62735/#comment263809>

    Technically the problem is using `path::join` to construct URIs.  It just so happens that
the default path separator on Windows is backslash ;)


- Joseph Wu


On Oct. 2, 2017, 2:35 p.m., Gaston Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62735/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2017, 2:35 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Joseph Wu, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> URIs pointing to local paths are not supported on Windows yet.
> 
> This patch disables on Windows the new tests that make sure that file
> URIs are fetched for tasks started by the default executor.
> 
> 
> Diffs
> -----
> 
>   src/tests/default_executor_tests.cpp 63952d97b76c3e16973705cb0b16140dd381b7ce 
> 
> 
> Diff: https://reviews.apache.org/r/62735/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message