mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 62731: Removed `MESOS_CPPFLAGS` from CMake.
Date Mon, 02 Oct 2017 21:37:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62731/#review186896
-----------------------------------------------------------


Ship it!





src/CMakeLists.txt
Lines 598 (patched)
<https://reviews.apache.org/r/62731/#comment263773>

    Hm... might as well fix the typo in `uquoted`.


- Joseph Wu


On Oct. 2, 2017, 11:58 a.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62731/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2017, 11:58 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Jeff Coffler, John Kordich, Joseph Wu, and
Li Li.
> 
> 
> Bugs: MESOS-8033
>     https://issues.apache.org/jira/browse/MESOS-8033
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This was a magic variable that was used to add compiler definitions
> globally. Instead, global definitions are now added explicitly with
> `add_definitions`, and others with `target_compile_definitions`.
> 
> 
> Diffs
> -----
> 
>   cmake/CompilationConfigure.cmake 9707e88fad29503e3205b8e25e8e625abfb60179 
>   src/CMakeLists.txt f8d56ae9fe1760559599a6ce7236714578c586e9 
> 
> 
> Diff: https://reviews.apache.org/r/62731/diff/2/
> 
> 
> Testing
> -------
> 
> This was the last patch which in this series which touched files other than documentation.
> 
> Tested the regular test targets on Windows with CMake with a clean build, everything
still builds and passes. Same on Linux.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message