mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 62729: Removed `LIBNAME_VERSION` from `External.cmake`.
Date Mon, 02 Oct 2017 21:04:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62729/#review186887
-----------------------------------------------------------


Ship it!





3rdparty/cmake/External.cmake
Lines 55-61 (original), 51-57 (patched)
<https://reviews.apache.org/r/62729/#comment263765>

    Since we're cleaning this code up, no need to repeat the example comments, as they are
already present in the function description.


- Joseph Wu


On Oct. 2, 2017, 11:52 a.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62729/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2017, 11:52 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Jeff Coffler, John Kordich, and Joseph Wu.
> 
> 
> Bugs: MESOS-8034
>     https://issues.apache.org/jira/browse/MESOS-8034
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This variable was superfluous as it is always given as an argument to
> `EXTERNAL`, and moreover, the variable of the same name is, in practice,
> always set in our `Versions.cmake` file. So `EXTERNAL` was pointlessly
> overwriting the variable with the same data.
> 
> 
> Diffs
> -----
> 
>   3rdparty/cmake/External.cmake 5bc51bd3822677040ab03edd576c876b74bd8afc 
> 
> 
> Diff: https://reviews.apache.org/r/62729/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message