mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 62353: Added a master-registry backed resource provider manager registry.
Date Mon, 02 Oct 2017 20:09:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62353/#review186876
-----------------------------------------------------------



FAIL: Mesos tests failed to build.

Reviews applied: `['62655', '62158', '61183', '61528', '62353']`

Failed command: `cmake.exe --build . --target mesos-tests --config Debug`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62353

Relevant logs:

- [mesos-tests-build-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62353/logs/mesos-tests-build-cmake-stdout.log):

```
  C:\mesos\mesos\src\resource_provider\registrar.cpp(301): error C2065: 'operations': undeclared
identifier [C:\mesos\src\mesos.vcxproj]
  C:\mesos\mesos\src\resource_provider\registrar.cpp(301): error C2228: left of '.clear' must
have class/struct/union [C:\mesos\src\mesos.vcxproj]
  C:\mesos\mesos\src\resource_provider\registrar.cpp(305): error C2653: 'AgentRegistrarProcess':
is not a class or namespace name [C:\mesos\src\mesos.vcxproj]
  C:\mesos\mesos\src\resource_provider\registrar.cpp(308): error C2653: 'Registrar': is not
a class or namespace name [C:\mesos\src\mesos.vcxproj]
  C:\mesos\mesos\src\resource_provider\registrar.cpp(308): error C2065: 'Operation': undeclared
identifier [C:\mesos\src\mesos.vcxproj]
  C:\mesos\mesos\src\resource_provider\registrar.cpp(308): error C2923: 'process::Owned':
'Operation' is not a valid template type argument for parameter 'T' [C:\mesos\src\mesos.vcxproj]
  C:\mesos\mesos\src\resource_provider\registrar.cpp(308): error C3203: 'Owned': unspecialized
class template can't be used as a template argument for template parameter '_Ty', expected
a real type [C:\mesos\src\mesos.vcxproj]
  C:\mesos\mesos\src\resource_provider\registrar.cpp(310): error C2065: 'updating': undeclared
identifier [C:\mesos\src\mesos.vcxproj]
  C:\mesos\mesos\src\resource_provider\registrar.cpp(324): error C2227: left of '->fail'
must point to class/struct/union/generic type [C:\mesos\src\mesos.vcxproj]
  C:\mesos\mesos\src\resource_provider\registrar.cpp(328): error C2065: 'error': undeclared
identifier [C:\mesos\src\mesos.vcxproj]
  C:\mesos\mesos\src\resource_provider\registrar.cpp(335): error C2065: 'variable': undeclared
identifier [C:\mesos\src\mesos.vcxproj]
  C:\mesos\mesos\src\resource_provider\registrar.cpp(336): error C2065: 'registry': undeclared
identifier [C:\mesos\src\mesos.vcxproj]
  C:\mesos\mesos\src\resource_provider\registrar.cpp(340): error C2653: 'Registrar': is not
a class or namespace name [C:\mesos\src\mesos.vcxproj]
  C:\mesos\mesos\src\resource_provider\registrar.cpp(340): error C2065: 'Operation': undeclared
identifier [C:\mesos\src\mesos.vcxproj]
  C:\mesos\mesos\src\resource_provider\registrar.cpp(340): error C2923: 'process::Owned':
'Operation' is not a valid template type argument for parameter 'T' [C:\mesos\src\mesos.vcxproj]
  C:\mesos\mesos\src\resource_provider\registrar.cpp(340): error C2514: 'process::Owned':
class has no constructors [C:\mesos\src\mesos.vcxproj]
  C:\mesos\mesos\src\resource_provider\registrar.cpp(343): error C2678: binary '->': no
operator found which takes a left-hand operand of type 'process::Owned' (or there is no acceptable
conversion) [C:\mesos\src\mesos.vcxproj]
  C:\mesos\mesos\src\resource_provider\registrar.cpp(343): error C2039: 'set': is not a member
of 'process::Owned' [C:\mesos\src\mesos.vcxproj]
  C:\mesos\mesos\src\resource_provider\registrar.cpp(346): error C2065: 'operations': undeclared
identifier [C:\mesos\src\mesos.vcxproj]
  C:\mesos\mesos\src\resource_provider\registrar.cpp(346): error C2228: left of '.empty' must
have class/struct/union [C:\mesos\src\mesos.vcxproj]
  C:\mesos\mesos\src\resource_provider\registrar.cpp(352): error C2653: 'AgentRegistrar':
is not a class or namespace name [C:\mesos\src\mesos.vcxproj]
  C:\mesos\mesos\src\resource_provider\registrar.cpp(355): error C4430: missing type specifier
- int assumed. Note: C++ does not support default-int [C:\mesos\src\mesos.vcxproj]
  C:\mesos\mesos\src\resource_provider\registrar.cpp(355): error C2061: syntax error: identifier
'AgentRegistrarProcess' [C:\mesos\src\mesos.vcxproj]
  C:\mesos\mesos\src\resource_provider\registrar.cpp(355): error C2612: trailing ')' illegal
in base/member initializer list [C:\mesos\src\mesos.vcxproj]

    236 Warning(s)
    100 Error(s)

Time Elapsed 00:32:12.28
```

- [mesos-tests-CMakeOutput.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62353/logs/mesos-tests-CMakeOutput.log):

```
  Creating directory "C:\mesos\CMakeFiles\CMakeTmp\Debug\".

  Creating directory "cmTC_e30c7.dir\Debug\cmTC_e30c7.tlog\".

InitializeBuildStatus:

  Creating "cmTC_e30c7.dir\Debug\cmTC_e30c7.tlog\unsuccessfulbuild" because "AlwaysCreate"
was specified.

ClCompile:

  C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.10.25017\bin\HostX64\x64\CL.exe
/c /Zi /W3 /WX- /diagnostics:classic /Od /Ob0 /D WIN32 /D _WINDOWS /D COMPILER_SUPPORTS_CXX11
/D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope
/Zc:inline /GR /Fo"cmTC_e30c7.dir\Debug\" /Fd"cmTC_e30c7.dir\Debug\vc141.pdb" /Gd /TP /errorReport:queue
C:\mesos\CMakeFiles\CMakeTmp\src.cxx

  Microsoft (R) C/C++ Optimizing Compiler Version 19.10.25019 for x64

  Copyright (C) Microsoft Corporation.  All rights reserved.

  

  cl /c /Zi /W3 /WX- /diagnostics:classic /Od /Ob0 /D WIN32 /D _WINDOWS /D COMPILER_SUPPORTS_CXX11
/D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope
/Zc:inline /GR /Fo"cmTC_e30c7.dir\Debug\" /Fd"cmTC_e30c7.dir\Debug\vc141.pdb" /Gd /TP /errorReport:queue
C:\mesos\CMakeFiles\CMakeTmp\src.cxx

  src.cxx

  

Link:

  C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.10.25017\bin\HostX64\x64\link.exe
/ERRORREPORT:QUEUE /OUT:"C:\mesos\CMakeFiles\CMakeTmp\Debug\cmTC_e30c7.exe" /INCREMENTAL /NOLOGO
kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib
comdlg32.lib advapi32.lib /MANIFEST /MANIFESTUAC:"level='asInvoker' uiAccess='false'" /manifest:embed
/DEBUG /PDB:"C:/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_e30c7.pdb" /SUBSYSTEM:CONSOLE /TLBID:1
/DYNAMICBASE /NXCOMPAT /IMPLIB:"C:/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_e30c7.lib" /MACHINE:X64
 /machine:x64 cmTC_e30c7.dir\Debug\src.obj

  cmTC_e30c7.vcxproj -> C:\mesos\CMakeFiles\CMakeTmp\Debug\cmTC_e30c7.exe

  cmTC_e30c7.vcxproj -> C:/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_e30c7.pdb (Full PDB)

FinalizeBuildStatus:

  Deleting file "cmTC_e30c7.dir\Debug\cmTC_e30c7.tlog\unsuccessfulbuild".

  Touching "cmTC_e30c7.dir\Debug\cmTC_e30c7.tlog\cmTC_e30c7.lastbuildstate".

Done Building Project "C:\mesos\CMakeFiles\CMakeTmp\cmTC_e30c7.vcxproj" (default targets).



Build succeeded.

    0 Warning(s)

    0 Error(s)



Time Elapsed 00:00:02.03


Source file was:
int main() { return 0; }
```

- [mesos-tests-CMakeError.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62353/logs/mesos-tests-CMakeError.log):

```
PrepareForBuild:

  Creating directory "cmTC_77309.dir\Debug\".

  Creating directory "C:\mesos\CMakeFiles\CMakeTmp\Debug\".

  Creating directory "cmTC_77309.dir\Debug\cmTC_77309.tlog\".

InitializeBuildStatus:

  Creating "cmTC_77309.dir\Debug\cmTC_77309.tlog\unsuccessfulbuild" because "AlwaysCreate"
was specified.

ClCompile:

  C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.10.25017\bin\HostX64\x64\CL.exe
/c /Zi /W3 /WX- /diagnostics:classic /MP /Od /Ob0 /D WIN32 /D _WINDOWS /D UNICODE /D _UNICODE
/D "CMAKE_INTDIR=\"Debug\"" /D _UNICODE /D UNICODE /Gm- /RTC1 /MTd /GS /fp:precise /Zc:wchar_t
/Zc:forScope /Zc:inline /Fo"cmTC_77309.dir\Debug\" /Fd"cmTC_77309.dir\Debug\vc141.pdb" /Gd
/TC /errorReport:queue C:\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c

  Microsoft (R) C/C++ Optimizing Compiler Version 19.10.25019 for x64

  Copyright (C) Microsoft Corporation.  All rights reserved.

  

  cl /c /Zi /W3 /WX- /diagnostics:classic /MP /Od /Ob0 /D WIN32 /D _WINDOWS /D UNICODE /D
_UNICODE /D "CMAKE_INTDIR=\"Debug\"" /D _UNICODE /D UNICODE /Gm- /RTC1 /MTd /GS /fp:precise
/Zc:wchar_t /Zc:forScope /Zc:inline /Fo"cmTC_77309.dir\Debug\" /Fd"cmTC_77309.dir\Debug\vc141.pdb"
/Gd /TC /errorReport:queue C:\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c

  CheckIncludeFile.c

  

C:\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c(1): fatal error C1083: Cannot open include
file: 'pthread.h': No such file or directory [C:\mesos\CMakeFiles\CMakeTmp\cmTC_77309.vcxproj]

Done Building Project "C:\mesos\CMakeFiles\CMakeTmp\cmTC_77309.vcxproj" (default targets)
-- FAILED.



Build FAILED.



"C:\mesos\CMakeFiles\CMakeTmp\cmTC_77309.vcxproj" (default target) (1) ->

(ClCompile target) -> 

  C:\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c(1): fatal error C1083: Cannot open include
file: 'pthread.h': No such file or directory [C:\mesos\CMakeFiles\CMakeTmp\cmTC_77309.vcxproj]



    0 Warning(s)

    1 Error(s)



Time Elapsed 00:00:01.29



```

- Mesos Reviewbot Windows


On Sept. 25, 2017, 7:42 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62353/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2017, 7:42 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds an implementation of the resource provider registrar
> backed by the master's registrar. With that it becomes possible to
> persist resource provider manager state in a single master registrar,
> but use the narrowly defined resource provider registry.
> 
> 
> Diffs
> -----
> 
>   src/master/registry.proto 8916ad30e1d240a177553eaab3a83c0223c268d8 
>   src/resource_provider/registrar.hpp PRE-CREATION 
>   src/resource_provider/registrar.cpp PRE-CREATION 
>   src/tests/resource_provider_manager_tests.cpp 3bc56b51526e9dd188423f7349e74246c3295c77

> 
> 
> Diff: https://reviews.apache.org/r/62353/diff/8/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message