mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <>
Subject Re: Review Request 62731: Removed `MESOS_CPPFLAGS` from CMake.
Date Mon, 02 Oct 2017 18:58:37 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Oct. 2, 2017, 11:58 a.m.)

Review request for mesos, Benjamin Bannier, Jeff Coffler, John Kordich, Joseph Wu, and Li

Repository: mesos


This was a magic variable that was used to add compiler definitions
globally. Instead, global definitions are now added explicitly with
`add_definitions`, and others with `target_compile_definitions`.


  cmake/CompilationConfigure.cmake 4cb8dddf93694722af2377c4a55a195260c8a0cb 
  src/CMakeLists.txt 1a828c4351ded36f51ccbbe67147da2f50b9cdb1 


Testing (updated)

This was the last patch which in this series which touched files other than documentation.

Tested the regular test targets on Windows with CMake with a clean build, everything still
builds and passes. Same on Linux.


Andrew Schwartzmeyer

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message