mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 62176: Added cmake dependency check for libsasl2 on non-Windows platforms.
Date Mon, 02 Oct 2017 18:55:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62176/#review186866
-----------------------------------------------------------


Ship it!




LGTM.

- Joseph Wu


On Sept. 27, 2017, 12:19 p.m., John Kordich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62176/
> -----------------------------------------------------------
> 
> (Updated Sept. 27, 2017, 12:19 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Jeff Coffler, Greg Mann, Joseph Wu, Li
Li, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3110
>     https://issues.apache.org/jira/browse/MESOS-3110
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added cmake dependency check for libsasl2 on non-Windows platforms.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt 2a183a4a46bf8bc97455fe02648407ba561b38e7 
> 
> 
> Diff: https://reviews.apache.org/r/62176/diff/3/
> 
> 
> Testing
> -------
> 
> I tested this on my Ubuntu 16.04 system. When the libsasl2 library doesn't exist, it
fails the cmake configure/build.  I did not test this on any other platform, but this code
is in a "if (NOT WIN32)" block and won't affect a Windows build.  I'm uncertain if there is
much support for other kinds of builds (like Mac OS), but this should be platform independent.
> 
> 
> Thanks,
> 
> John Kordich
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message