mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Review Request 62730: Used `TRUE|FALSE` instead of `ON|OFF` consistently in CMake.
Date Mon, 02 Oct 2017 18:53:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62730/
-----------------------------------------------------------

Review request for mesos, Benjamin Bannier, Jeff Coffler, John Kordich, Joseph Wu, and Li
Li.


Bugs: MESOS-3107
    https://issues.apache.org/jira/browse/MESOS-3107


Repository: mesos


Description
-------

While these are equivalent values to CMake, we should be consistent.
Also made uses of `option` consistent, and moved `ENABLE_JAVA` to the
3rdparty section.


Diffs
-----

  cmake/CompilationConfigure.cmake 4cb8dddf93694722af2377c4a55a195260c8a0cb 


Diff: https://reviews.apache.org/r/62730/diff/1/


Testing
-------


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message