mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Review Request 62729: Removed `LIBNAME_VERSION` from `External.cmake`.
Date Mon, 02 Oct 2017 18:52:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62729/
-----------------------------------------------------------

Review request for mesos, Benjamin Bannier, Jeff Coffler, John Kordich, and Joseph Wu.


Bugs: MESOS-8034
    https://issues.apache.org/jira/browse/MESOS-8034


Repository: mesos


Description
-------

This variable was superfluous as it is always given as an argument to
`EXTERNAL`, and moreover, the variable of the same name is, in practice,
always set in our `Versions.cmake` file. So `EXTERNAL` was pointlessly
overwriting the variable with the same data.


Diffs
-----

  3rdparty/cmake/External.cmake 5bc51bd3822677040ab03edd576c876b74bd8afc 


Diff: https://reviews.apache.org/r/62729/diff/1/


Testing
-------


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message