mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 62105: Enabled building of the Cyrus SASL CRAM MD5 lib on Windows.
Date Mon, 02 Oct 2017 18:03:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62105/#review186622
-----------------------------------------------------------


Ship it!




I can make the tweaks listed below before committing.

Tested on Windows via:
```
cmake --build . --config Debug --target sasl2-2.1.27rc3
```


3rdparty/cyrus-sasl-2.1.27rc3.patch
Lines 10-14 (patched)
<https://reviews.apache.org/r/62105/#comment263332>

    These could be `string(APPEND ...)`



3rdparty/cyrus-sasl-2.1.27rc3.patch
Lines 25-26 (patched)
<https://reviews.apache.org/r/62105/#comment263331>

    What is this comment referring to?
    
    I can remove it if not relevant.



3rdparty/cyrus-sasl-2.1.27rc3.patch
Lines 104-124 (patched)
<https://reviews.apache.org/r/62105/#comment263697>

    Instead of commenting out, we can just delete these definitions within the patch.


- Joseph Wu


On Sept. 27, 2017, 12:19 p.m., John Kordich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62105/
> -----------------------------------------------------------
> 
> (Updated Sept. 27, 2017, 12:19 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Jeff Coffler, Greg Mann, Joseph Wu, Li
Li, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3384
>     https://issues.apache.org/jira/browse/MESOS-3384
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Enabled building of the Cyrus SASL CRAM MD5 lib on Windows.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt 2a183a4a46bf8bc97455fe02648407ba561b38e7 
>   3rdparty/cmake/Versions.cmake 0b62ae96817ade616f8dfc52cf8df995f8fd8927 
>   3rdparty/cyrus-sasl-2.1.27rc3.patch PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62105/diff/5/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> John Kordich
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message