mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Till Toenshoff <toensh...@me.com>
Subject Re: Review Request 62594: Updated scheduler library for modularized HTTP authenticatee use.
Date Mon, 02 Oct 2017 10:28:20 GMT


> On Sept. 27, 2017, 10:07 p.m., Greg Mann wrote:
> > src/scheduler/flags.hpp
> > Lines 57-59 (patched)
> > <https://reviews.apache.org/r/62594/diff/1/?file=1836050#file1836050line58>
> >
> >     s/kept in in sync/kept in sync/
> >     
> >     Also, this seems bad :) (also for modules_dir) I wonder if we have a ticket
for eliminating this code duplication thru common inheritance?
> 
> Till Toenshoff wrote:
>     Yes, lets fix this particular stuff via a ticket and flags inheritance.

https://issues.apache.org/jira/browse/MESOS-8044


- Till


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62594/#review186483
-----------------------------------------------------------


On Sept. 26, 2017, 10:54 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62594/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2017, 10:54 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Armand Grillet, Benjamin Bannier, Greg Mann,
Kapil Arya, and Vinod Kone.
> 
> 
> Bugs: MESOS-8021
>     https://issues.apache.org/jira/browse/MESOS-8021
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/scheduler/flags.hpp 1e8efc06b40b17d6fa9d9516a83893485804fc72 
>   src/scheduler/scheduler.cpp 78f53707364ab988bcc53ec2c95490df04cd9a6c 
> 
> 
> Diff: https://reviews.apache.org/r/62594/diff/1/
> 
> 
> Testing
> -------
> 
> Integration test in external project. Further tests upcoming.
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message