mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Till Toenshoff <toensh...@me.com>
Subject Re: Review Request 62595: Added test module wrapping the basic HTTP authenticatee.
Date Mon, 02 Oct 2017 09:46:27 GMT


> On Sept. 27, 2017, 10:17 p.m., Greg Mann wrote:
> > src/examples/test_http_authenticator_module.cpp
> > Line 30 (original), 34 (patched)
> > <https://reviews.apache.org/r/62595/diff/1/?file=1836121#file1836121line36>
> >
> >     Is there a reason to have `using namespace mesos` here instead of `namespace
mesos {`?

This is not really a part of Mesos but example code. None of our (module) examples put their
code into the `mesos` namespace.


- Till


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62595/#review186495
-----------------------------------------------------------


On Sept. 26, 2017, 10:54 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62595/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2017, 10:54 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Armand Grillet, Benjamin Bannier, Greg Mann,
Kapil Arya, and Vinod Kone.
> 
> 
> Bugs: MESOS-8017
>     https://issues.apache.org/jira/browse/MESOS-8017
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adds test module wrapping the basic HTTP authenticatee. Additionally
> renames the former testhttpauthenticator library to accomodate for
> the added test HTTP authenticatee module.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 93ed2bf55447e3e470d9bea8a0b61ce78aad1900 
>   src/examples/CMakeLists.txt d4f1af4f072efdc68fa0b722f42b1d8aa1779b6e 
>   src/examples/test_http_authenticator_module.cpp a2fdc282e741f36a429923a7d6082750a89b7b13

>   src/tests/CMakeLists.txt def233d13f627f58362fdc61ac3e9c104d65fe7e 
>   src/tests/module.cpp 5b83fd6358ddea4c9d849b8992e1a6040ef74505 
> 
> 
> Diff: https://reviews.apache.org/r/62595/diff/1/
> 
> 
> Testing
> -------
> 
> Integration test in external project. Further tests upcoming.
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message