mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Till Toenshoff <toensh...@me.com>
Subject Re: Review Request 62587: Added HTTP authenticatee interface definition.
Date Mon, 02 Oct 2017 08:50:35 GMT


> On Sept. 28, 2017, 3:54 p.m., Benjamin Bannier wrote:
> > include/mesos/authentication/http/authenticatee.hpp
> > Lines 48-49 (patched)
> > <https://reviews.apache.org/r/62587/diff/1/?file=1835964#file1835964line48>
> >
> >     Since our Doxygen setup uses `JAVADOC_AUTOBRIEF` which makes the first paragraph
a brief description, can we add one here?, e.g.,
> >     
> >         Create a HTTP request for authentication.

Our docs/doxygen-style-guide.md does not mention this tag, hence I am not sure our site renderer
swallows that properly. Could you please enhance it that way?


- Till


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62587/#review186390
-----------------------------------------------------------


On Sept. 26, 2017, 10:54 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62587/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2017, 10:54 p.m.)
> 
> 
> Review request for mesos, Armand Grillet, Benjamin Bannier, Greg Mann, and Kapil Arya.
> 
> 
> Bugs: MESOS-8016
>     https://issues.apache.org/jira/browse/MESOS-8016
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> see summary.
> 
> 
> Diffs
> -----
> 
>   include/mesos/authentication/http/authenticatee.hpp PRE-CREATION 
>   src/Makefile.am 93ed2bf55447e3e470d9bea8a0b61ce78aad1900 
> 
> 
> Diff: https://reviews.apache.org/r/62587/diff/1/
> 
> 
> Testing
> -------
> 
> Integration test in external project. Further tests upcoming.
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message