|
Re: Review Request 61981: Added unit test for killing the default executor process. |
|
| Gilbert Song |
Re: Review Request 61981: Added unit test for killing the default executor process. |
Fri, 01 Sep, 06:23 |
| Gilbert Song |
Re: Review Request 61981: Added unit test for killing the default executor process. |
Fri, 01 Sep, 06:23 |
|
Re: Review Request 61991: Added several logs to the C++ part of the v1-v0 adapter. |
|
| Anand Mazumdar |
Re: Review Request 61991: Added several logs to the C++ part of the v1-v0 adapter. |
Fri, 01 Sep, 06:27 |
| Alexander Rukletsov |
Re: Review Request 61991: Added several logs to the C++ part of the v1-v0 adapter. |
Fri, 01 Sep, 08:36 |
|
Re: Review Request 61849: Improved consistency of cout/cerr and glog usage in main functions. |
|
| Till Toenshoff |
Re: Review Request 61849: Improved consistency of cout/cerr and glog usage in main functions. |
Fri, 01 Sep, 09:16 |
|
Re: Review Request 61810: Added a function to apply offer operations. |
|
| Jan Schlicht |
Re: Review Request 61810: Added a function to apply offer operations. |
Fri, 01 Sep, 10:23 |
|
Re: Review Request 61946: Added validation of resource provider operations. |
|
| Jan Schlicht |
Re: Review Request 61946: Added validation of resource provider operations. |
Fri, 01 Sep, 10:23 |
| Jie Yu |
Re: Review Request 61946: Added validation of resource provider operations. |
Wed, 06 Sep, 21:41 |
|
Re: Review Request 61947: Implemented handling of resource provider offer operations. |
|
| Jan Schlicht |
Re: Review Request 61947: Implemented handling of resource provider offer operations. |
Fri, 01 Sep, 10:23 |
| Jan Schlicht |
Re: Review Request 61947: Implemented handling of resource provider offer operations. |
Thu, 07 Sep, 12:27 |
| Mesos Reviewbot Windows |
Re: Review Request 61947: Implemented handling of resource provider offer operations. |
Thu, 07 Sep, 17:01 |
| Mesos Reviewbot |
Re: Review Request 61947: Implemented handling of resource provider offer operations. |
Fri, 08 Sep, 03:05 |
| Armand Grillet |
Review Request 62037: Added logging::initialize to main functions that use glog. |
Fri, 01 Sep, 15:47 |
| Mesos Reviewbot |
Re: Review Request 62037: Added logging::initialize to main functions that use glog. |
Fri, 01 Sep, 17:55 |
| Alexander Rukletsov |
Re: Review Request 62037: Added logging::initialize to main functions that use glog. |
Mon, 04 Sep, 13:39 |
| Armand Grillet |
Re: Review Request 62037: Added logging::initialize to main functions that use glog. |
Tue, 05 Sep, 14:29 |
| Alexander Rukletsov |
Re: Review Request 62037: Added logging::initialize to main functions that use glog. |
Tue, 05 Sep, 15:41 |
| Armand Grillet |
Re: Review Request 62037: Added logging::initialize to main functions that use glog. |
Wed, 06 Sep, 10:03 |
| Mesos Reviewbot Windows |
Re: Review Request 62037: Added logging::initialize to main functions that use glog. |
Tue, 05 Sep, 09:58 |
| Armand Grillet |
Re: Review Request 62037: Added logging::initialize to main functions that use glog. |
Wed, 06 Sep, 09:57 |
| Mesos Reviewbot Windows |
Re: Review Request 62037: Added logging::initialize to main functions that use glog. |
Wed, 06 Sep, 13:55 |
| Andrei Budnik |
Re: Review Request 62037: Added logging::initialize to main functions that use glog. |
Fri, 08 Sep, 12:14 |
| Armand Grillet |
Re: Review Request 62037: Added logging::initialize to main functions that use glog. |
Mon, 11 Sep, 14:59 |
| Mesos Reviewbot Windows |
Re: Review Request 62037: Added logging::initialize to main functions that use glog. |
Mon, 11 Sep, 22:11 |
| Armand Grillet |
Re: Review Request 62037: Added logging::initialize to main functions that use glog. |
Thu, 14 Sep, 08:36 |
| Mesos Reviewbot Windows |
Re: Review Request 62037: Added logging::initialize to main functions that use glog. |
Thu, 14 Sep, 10:46 |
| Mesos Reviewbot |
Re: Review Request 62037: Added logging::initialize to main functions that use glog. |
Fri, 15 Sep, 03:30 |
| Mesos Reviewbot Windows |
Re: Review Request 62037: Added logging::initialize to main functions that use glog. |
Fri, 15 Sep, 16:45 |
| Armand Grillet |
Re: Review Request 62037: Added logging::initialize to main functions that use glog. |
Mon, 18 Sep, 14:27 |
| Andrei Budnik |
Re: Review Request 62037: Added logging::initialize to main functions that use glog. |
Mon, 18 Sep, 16:18 |
| Alexander Rukletsov |
Re: Review Request 62037: Added logging::initialize to main functions that use glog. |
Mon, 18 Sep, 19:11 |
| Alexander Rukletsov |
Re: Review Request 62037: Added logging::initialize to main functions that use glog. |
Mon, 18 Sep, 19:45 |
| Mesos Reviewbot Windows |
Re: Review Request 62037: Added logging::initialize to main functions that use glog. |
Mon, 18 Sep, 16:23 |
| Alexander Rukletsov |
Re: Review Request 62037: Added logging::initialize to main functions that use glog. |
Mon, 18 Sep, 19:42 |
| Alexander Rukletsov |
Re: Review Request 62037: Added logging::initialize to main functions that use glog. |
Mon, 18 Sep, 21:22 |
|
Re: Review Request 60960: Added an enum to track Metric semantics. |
|
| Jiang Yan Xu |
Re: Review Request 60960: Added an enum to track Metric semantics. |
Fri, 01 Sep, 18:02 |
| James Peach |
Re: Review Request 60960: Added an enum to track Metric semantics. |
Fri, 01 Sep, 18:07 |
|
Re: Review Request 61126: Converted Timer value to counting semantics. |
|
| Jiang Yan Xu |
Re: Review Request 61126: Converted Timer value to counting semantics. |
Fri, 01 Sep, 18:24 |
| James Peach |
Re: Review Request 61126: Converted Timer value to counting semantics. |
Fri, 01 Sep, 18:26 |
|
Re: Review Request 61125: Track the total number of time series samples. |
|
| Jiang Yan Xu |
Re: Review Request 61125: Track the total number of time series samples. |
Fri, 01 Sep, 18:30 |
| James Peach |
Re: Review Request 61125: Track the total number of time series samples. |
Fri, 01 Sep, 22:39 |
|
Re: Review Request 61982: Cleaned up DefaultExecutor tests. |
|
| Mesos Reviewbot |
Re: Review Request 61982: Cleaned up DefaultExecutor tests. |
Fri, 01 Sep, 20:48 |
| Greg Mann |
Re: Review Request 61982: Cleaned up DefaultExecutor tests. |
Fri, 08 Sep, 18:54 |
| Gastón Kleiman |
Re: Review Request 61982: Cleaned up DefaultExecutor tests. |
Sat, 09 Sep, 00:03 |
| Greg Mann |
Re: Review Request 61982: Cleaned up DefaultExecutor tests. |
Tue, 12 Sep, 18:45 |
| Gastón Kleiman |
Review Request 62042: Change `EXPECT` to `ASSERT` when relying on the assertion afterwards. |
Fri, 01 Sep, 21:28 |
| Joerg Schad |
Re: Review Request 62042: Change `EXPECT` to `ASSERT` when relying on the assertion afterwards. |
Fri, 01 Sep, 22:22 |
| Mesos Reviewbot |
Re: Review Request 62042: Change `EXPECT` to `ASSERT` when relying on the assertion afterwards. |
Fri, 01 Sep, 22:39 |
| Greg Mann |
Re: Review Request 62042: Change `EXPECT` to `ASSERT` when relying on the assertion afterwards. |
Thu, 07 Sep, 17:45 |
| Mesos Reviewbot Windows |
Re: Review Request 62042: Change `EXPECT` to `ASSERT` when relying on the assertion afterwards. |
Thu, 07 Sep, 18:01 |
| Gastón Kleiman |
Re: Review Request 62042: Change `EXPECT` to `ASSERT` when relying on the assertion afterwards. |
Thu, 07 Sep, 18:09 |
| Mesos Reviewbot Windows |
Re: Review Request 62042: Change `EXPECT` to `ASSERT` when relying on the assertion afterwards. |
Thu, 07 Sep, 20:01 |
| Greg Mann |
Re: Review Request 62042: Change `EXPECT` to `ASSERT` when relying on the assertion afterwards. |
Fri, 08 Sep, 21:01 |
| Greg Mann |
Re: Review Request 62042: Change `EXPECT` to `ASSERT` when relying on the assertion afterwards. |
Fri, 08 Sep, 21:22 |
| Gastón Kleiman |
Re: Review Request 62042: Changed `EXPECT` to `ASSERT` when relying on the assertion afterwards. |
Sat, 09 Sep, 00:03 |
| Mesos Reviewbot Windows |
Re: Review Request 62042: Changed `EXPECT` to `ASSERT` when relying on the assertion afterwards. |
Sat, 09 Sep, 01:44 |
| Mesos Reviewbot |
Re: Review Request 62042: Changed `EXPECT` to `ASSERT` when relying on the assertion afterwards. |
Tue, 12 Sep, 17:22 |
| Zhitao Li |
Review Request 62040: Also log attached path in agent. |
Fri, 01 Sep, 22:53 |
| Benjamin Mahler |
Re: Review Request 62040: Also log attached path in agent. |
Wed, 06 Sep, 20:57 |
| Zhitao Li |
Re: Review Request 62040: Also log attached virtual path in agent. |
Thu, 07 Sep, 21:17 |
| Zhitao Li |
Re: Review Request 62040: Also log attached virtual path in agent. |
Thu, 07 Sep, 21:16 |
| Benjamin Mahler |
Re: Review Request 62040: Also log attached virtual path in agent. |
Fri, 08 Sep, 02:04 |
| Zhitao Li |
Re: Review Request 62040: Also log attached virtual path in agent. |
Mon, 11 Sep, 23:16 |
| Zhitao Li |
Review Request 62047: Allowed look up latest executor directory by virtual path. |
Fri, 01 Sep, 22:54 |
| Mesos Reviewbot |
Re: Review Request 62047: Allowed look up latest executor directory by virtual path. |
Sat, 02 Sep, 00:38 |
| Benjamin Mahler |
Re: Review Request 62047: Allowed look up latest executor directory by virtual path. |
Wed, 06 Sep, 21:28 |
| Zhitao Li |
Re: Review Request 62047: Allowed look up latest executor directory by virtual path. |
Thu, 07 Sep, 21:18 |
| Mesos Reviewbot Windows |
Re: Review Request 62047: Allowed look up latest executor directory by virtual path. |
Thu, 07 Sep, 11:41 |
| Zhitao Li |
Re: Review Request 62047: Allowed look up latest executor directory by virtual path. |
Thu, 07 Sep, 21:18 |
| Mesos Reviewbot Windows |
Re: Review Request 62047: Allowed look up latest executor directory by virtual path. |
Thu, 07 Sep, 23:15 |
| Benjamin Mahler |
Re: Review Request 62047: Allowed look up latest executor directory by virtual path. |
Fri, 08 Sep, 02:33 |
| Mesos Reviewbot |
Re: Review Request 62047: Allowed look up latest executor directory by virtual path. |
Sun, 10 Sep, 22:28 |
| Zhitao Li |
Re: Review Request 62047: Allowed look up latest executor directory by virtual path. |
Mon, 11 Sep, 23:17 |
| Zhitao Li |
Re: Review Request 62047: Allowed look up latest executor directory by virtual path. |
Mon, 11 Sep, 23:18 |
| Mesos Reviewbot Windows |
Re: Review Request 62047: Allowed look up latest executor directory by virtual path. |
Tue, 12 Sep, 09:56 |
| Zhitao Li |
Re: Review Request 62047: Allowed look up latest executor directory by virtual path. |
Wed, 13 Sep, 01:25 |
| Benjamin Mahler |
Re: Review Request 62047: Allowed look up latest executor directory by virtual path. |
Tue, 19 Sep, 21:14 |
| Benjamin Mahler |
Review Request 62049: Fixed an OOM due to a send loop for SSL sockets. |
Sat, 02 Sep, 00:38 |
| Chun-Hung Hsiao |
Re: Review Request 62049: Fixed an OOM due to a send loop for SSL sockets. |
Sat, 02 Sep, 02:29 |
| Jie Yu |
Re: Review Request 62049: Fixed an OOM due to a send loop for SSL sockets. |
Sat, 02 Sep, 02:56 |
| Benjamin Mahler |
Re: Review Request 62049: Fixed an OOM due to a send loop for SSL sockets. |
Sat, 02 Sep, 03:10 |
| Benjamin Mahler |
Review Request 62050: Added a test to reproduce the OOM issue in MESOS-7934. |
Sat, 02 Sep, 00:38 |
| Chun-Hung Hsiao |
Re: Review Request 62050: Added a test to reproduce the OOM issue in MESOS-7934. |
Sat, 02 Sep, 02:35 |
| Jie Yu |
Re: Review Request 62050: Added a test to reproduce the OOM issue in MESOS-7934. |
Sat, 02 Sep, 03:01 |
| Benjamin Mahler |
Re: Review Request 62050: Added a test to reproduce the OOM issue in MESOS-7934. |
Sat, 02 Sep, 03:15 |
| Benjamin Mahler |
Re: Review Request 62050: Added a test to reproduce the OOM issue in MESOS-7934. |
Sat, 02 Sep, 03:15 |
| Benjamin Mahler |
Review Request 62051: Clarified some issues in the LibeventSSLSocket event_callback logic. |
Sat, 02 Sep, 00:38 |
| Mesos Reviewbot |
Re: Review Request 62051: Clarified some issues in the LibeventSSLSocket event_callback logic. |
Sat, 02 Sep, 02:28 |
| Chun-Hung Hsiao |
Re: Review Request 62051: Clarified some issues in the LibeventSSLSocket event_callback logic. |
Sat, 02 Sep, 02:37 |
| Jie Yu |
Re: Review Request 62051: Clarified some issues in the LibeventSSLSocket event_callback logic. |
Sat, 02 Sep, 03:09 |
| Benjamin Mahler |
Re: Review Request 62051: Clarified some issues in the LibeventSSLSocket event_callback logic. |
Sat, 02 Sep, 03:15 |
| Benjamin Mahler |
Re: Review Request 62051: Clarified some issues in the LibeventSSLSocket event_callback logic. |
Sat, 02 Sep, 03:16 |
| Mesos Reviewbot |
Re: Review Request 62051: Clarified some issues in the LibeventSSLSocket event_callback logic. |
Sat, 02 Sep, 04:20 |
|
Re: Review Request 62017: Allows port mapper plugin to have optional args. |
|
| Qian Zhang |
Re: Review Request 62017: Allows port mapper plugin to have optional args. |
Sat, 02 Sep, 02:08 |
| Qian Zhang |
Re: Review Request 62017: Allows port mapper plugin to have optional args. |
Sun, 03 Sep, 14:35 |
| Qian Zhang |
Re: Review Request 62017: Allows port mapper plugin to have optional args. |
Tue, 05 Sep, 01:40 |
| Deepak Goel |
Re: Review Request 62017: Allows port mapper plugin to have optional args. |
Tue, 05 Sep, 21:47 |
| Qian Zhang |
Re: Review Request 62017: Allows port mapper plugin to have optional args. |
Tue, 05 Sep, 23:28 |
| Mesos Reviewbot Windows |
Re: Review Request 62017: Allows port mapper plugin to have optional args. |
Tue, 05 Sep, 23:42 |
| Deepak Goel |
Re: Review Request 62017: Allows port mapper plugin to have optional args. |
Wed, 06 Sep, 00:25 |
| Avinash sridharan |
Re: Review Request 62017: Allows port mapper plugin to have optional args. |
Wed, 06 Sep, 02:09 |
| Deepak Goel |
Re: Review Request 62017: Allows port mapper plugin to have optional args. |
Wed, 06 Sep, 02:46 |
| Avinash sridharan |
Re: Review Request 62017: Allows port mapper plugin to have optional args. |
Thu, 07 Sep, 04:08 |
| Mesos Reviewbot Windows |
Re: Review Request 62017: Allows port mapper plugin to have optional args. |
Wed, 06 Sep, 02:14 |
| Mesos Reviewbot |
Re: Review Request 62017: Allows port mapper plugin to have optional args. |
Wed, 06 Sep, 03:55 |
|
Re: Review Request 61323: Added `picojson` interface library. |
|
| Joseph Wu |
Re: Review Request 61323: Added `picojson` interface library. |
Sat, 02 Sep, 14:21 |
|
Re: Review Request 61308: Updated the ZooKeeper patch. |
|
| Joseph Wu |
Re: Review Request 61308: Updated the ZooKeeper patch. |
Sat, 02 Sep, 14:26 |
|
Re: Review Request 61327: Imported `zlib` library. |
|
| Joseph Wu |
Re: Review Request 61327: Imported `zlib` library. |
Sat, 02 Sep, 14:32 |
|
Re: Review Request 61330: Added `nvml` interface library. |
|
| Joseph Wu |
Re: Review Request 61330: Added `nvml` interface library. |
Sat, 02 Sep, 14:35 |
|
Re: Review Request 61334: Imported `http_parser` library. |
|
| Joseph Wu |
Re: Review Request 61334: Imported `http_parser` library. |
Sat, 02 Sep, 14:41 |
|
Re: Review Request 61336: Prioritized provided paths in `FindPackageHelper`. |
|
| Joseph Wu |
Re: Review Request 61336: Prioritized provided paths in `FindPackageHelper`. |
Sat, 02 Sep, 14:54 |
|
Re: Review Request 61337: Imported `apr` library. |
|
| Joseph Wu |
Re: Review Request 61337: Imported `apr` library. |
Sat, 02 Sep, 15:01 |
| Benjamin Hindman |
Review Request 62053: Removed garbage collector. |
Sat, 02 Sep, 15:07 |
| Mesos Reviewbot |
Re: Review Request 62053: Removed garbage collector. |
Tue, 05 Sep, 13:36 |
| Mesos Reviewbot Windows |
Re: Review Request 62053: Removed garbage collector. |
Tue, 05 Sep, 19:31 |
| Benjamin Mahler |
Re: Review Request 62053: Removed garbage collector. |
Wed, 06 Sep, 21:22 |
| Benjamin Mahler |
Re: Review Request 62053: Removed garbage collector. |
Thu, 07 Sep, 01:51 |
| Benjamin Mahler |
Re: Review Request 62053: Removed garbage collector. |
Thu, 07 Sep, 02:15 |
|
Re: Review Request 61340: Imported `leveldb` library. |
|
| Joseph Wu |
Re: Review Request 61340: Imported `leveldb` library. |
Sat, 02 Sep, 15:09 |
|
Re: Review Request 61343: Supported finding the correct subversion libraries on macOS. |
|
| Joseph Wu |
Re: Review Request 61343: Supported finding the correct subversion libraries on macOS. |
Sat, 02 Sep, 15:15 |
|
Re: Review Request 61344: Imported `svn` library. |
|
| Joseph Wu |
Re: Review Request 61344: Imported `svn` library. |
Sat, 02 Sep, 15:47 |
|
Re: Review Request 61346: Imported `gtest` and `gmock` libraries with a `googletest` interface. |
|
| Joseph Wu |
Re: Review Request 61346: Imported `gtest` and `gmock` libraries with a `googletest` interface. |
Sat, 02 Sep, 15:56 |
|
Re: Review Request 61350: Removed `GroupSource` usage from `libprocess`. |
|
| Joseph Wu |
Re: Review Request 61350: Removed `GroupSource` usage from `libprocess`. |
Sat, 02 Sep, 16:11 |
|
Re: Review Request 58048: Added id to Resource.DiskInfo. |
|
| Jie Yu |
Re: Review Request 58048: Added id to Resource.DiskInfo. |
Sat, 02 Sep, 16:27 |
| Benjamin Bannier |
Re: Review Request 58048: Added 'id' and 'metadata' fields to 'Resource.DiskInfo.Source'. |
Tue, 12 Sep, 13:14 |
| Jie Yu |
Re: Review Request 58048: Added id to Resource.DiskInfo. |
Wed, 06 Sep, 17:15 |
| Benjamin Bannier |
Re: Review Request 58048: Added 'id' and 'metadata' fields to 'Resource.DiskInfo.Source'. |
Tue, 12 Sep, 13:14 |
| Benjamin Bannier |
Re: Review Request 58048: Added 'id' and 'metadata' fields to 'Resource.DiskInfo.Source'. |
Tue, 12 Sep, 13:14 |
| Jie Yu |
Re: Review Request 58048: Added 'id' and 'metadata' fields to 'Resource.DiskInfo.Source'. |
Wed, 13 Sep, 00:34 |
| Benjamin Bannier |
Re: Review Request 58048: Added 'id' and 'metadata' fields to 'Resource.DiskInfo.Source'. |
Fri, 15 Sep, 13:16 |
| Benjamin Bannier |
Re: Review Request 58048: Added 'id' and 'metadata' fields to 'Resource.DiskInfo.Source'. |
Wed, 13 Sep, 15:23 |
| Jie Yu |
Re: Review Request 58048: Added 'id' and 'metadata' fields to 'Resource.DiskInfo.Source'. |
Mon, 18 Sep, 17:06 |
| Benjamin Bannier |
Re: Review Request 58048: Added 'id' and 'metadata' fields to 'Resource.DiskInfo.Source'. |
Tue, 19 Sep, 19:12 |
| Benjamin Bannier |
Re: Review Request 58048: Added 'id' and 'metadata' fields to 'Resource.DiskInfo.Source'. |
Tue, 19 Sep, 16:53 |
| Benjamin Bannier |
Re: Review Request 58048: Added 'id' and 'metadata' fields to 'Resource.DiskInfo.Source'. |
Tue, 12 Sep, 13:14 |
| Benjamin Bannier |
Re: Review Request 58048: Added 'id' and 'metadata' fields to 'Resource.DiskInfo.Source'. |
Tue, 12 Sep, 13:14 |
|
Re: Review Request 61351: Removed `GroupSource.cmake`. |
|
| Joseph Wu |
Re: Review Request 61351: Removed `GroupSource.cmake`. |
Sat, 02 Sep, 16:35 |
| Mesos Reviewbot |
Re: Review Request 61351: Removed `GroupSource.cmake`. |
Sat, 02 Sep, 18:54 |
|
Re: Review Request 61357: Imported `libev` and `libevent` libraries. |
|
| Joseph Wu |
Re: Review Request 61357: Imported `libev` and `libevent` libraries. |
Sat, 02 Sep, 16:58 |
|
Re: Review Request 61291: Imported `glog` library. |
|
| Joseph Wu |
Re: Review Request 61291: Imported `glog` library. |
Sat, 02 Sep, 17:42 |
|
Re: Review Request 61314: Added `boost` interface library. |
|
| Joseph Wu |
Re: Review Request 61314: Added `boost` interface library. |
Sat, 02 Sep, 17:44 |
|
Re: Review Request 61295: Linked `stout` interface library to `protobuf` imported library. |
|
| Andrew Schwartzmeyer |
Re: Review Request 61295: Linked `stout` interface library to `protobuf` imported library. |
Sat, 02 Sep, 17:52 |
|
Re: Review Request 61292: Linked `stout` interface library to `glog` imported library. |
|
| Joseph Wu |
Re: Review Request 61292: Linked `stout` interface library to `glog` imported library. |
Sat, 02 Sep, 18:07 |
|
Re: Review Request 61347: Linked `stout-tests` to `googletest`. |
|
| Joseph Wu |
Re: Review Request 61347: Linked `stout-tests` to `googletest`. |
Sat, 02 Sep, 20:03 |
| Mesos Reviewbot |
Re: Review Request 61347: Linked `stout-tests` to `googletest`. |
Sat, 02 Sep, 20:55 |
|
Re: Review Request 61293: Removed `glog` configuration from `libprocess`. |
|
| Joseph Wu |
Re: Review Request 61293: Removed `glog` configuration from `libprocess`. |
Sat, 02 Sep, 20:08 |