From reviews-return-66528-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Sep 29 17:46:28 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 71D1110715 for ; Fri, 29 Sep 2017 17:46:28 +0000 (UTC) Received: (qmail 25738 invoked by uid 500); 29 Sep 2017 17:46:28 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 25705 invoked by uid 500); 29 Sep 2017 17:46:28 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 25664 invoked by uid 99); 29 Sep 2017 17:46:28 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 29 Sep 2017 17:46:28 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id A2DCE180DCE; Fri, 29 Sep 2017 17:46:27 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.999 X-Spam-Level: ** X-Spam-Status: No, score=2.999 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id b1HuiSiZqCgN; Fri, 29 Sep 2017 17:46:26 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id C687A5F3CE; Fri, 29 Sep 2017 17:46:25 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 20A96E0041; Fri, 29 Sep 2017 17:46:25 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 53CD7C4083E; Fri, 29 Sep 2017 17:46:22 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2881821294466551405==" MIME-Version: 1.0 Subject: Re: Review Request 62479: Removed the logic for removing the latest symlink on the agent. From: Anand Mazumdar To: Vinod Kone Cc: Anand Mazumdar , mesos Date: Fri, 29 Sep 2017 17:46:22 -0000 Message-ID: <20170929174622.891.99233@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Anand Mazumdar X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/62479/ X-Sender: Anand Mazumdar References: <20170926185856.42294.57318@reviews-vm2.apache.org> In-Reply-To: <20170926185856.42294.57318@reviews-vm2.apache.org> Reply-To: Anand Mazumdar X-ReviewRequest-Repository: mesos --===============2881821294466551405== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Sept. 26, 2017, 6:58 p.m., Vinod Kone wrote: > > Can you also add a blurb to CHANGELOG about the new semantics? I think it's worth calling out. > > Vinod Kone wrote: > don't forget this! Yep! I need to add the Agent Lifecycle feature to the `CHANGELOG`; so would do it as part of that. Haven't got to it yet. :) - Anand ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62479/#review186311 ----------------------------------------------------------- On Sept. 21, 2017, 8:28 p.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62479/ > ----------------------------------------------------------- > > (Updated Sept. 21, 2017, 8:28 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-7445 > https://issues.apache.org/jira/browse/MESOS-7445 > > > Repository: mesos > > > Description > ------- > > This change removes the logic of removing the latest symlink on > receiving the shutdown message from the Mesos master. This ensures > that agents come back with the same agent ID upon a successful > shutdown similar to the behavior when they come back post a reboot. > > > Diffs > ----- > > src/slave/slave.cpp 01020a624bdd67ee6371f607d897ad71a2cdcc82 > > > Diff: https://reviews.apache.org/r/62479/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Anand Mazumdar > > --===============2881821294466551405==--