From reviews-return-66483-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Sep 28 14:55:04 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C06D0102DB for ; Thu, 28 Sep 2017 14:55:04 +0000 (UTC) Received: (qmail 8065 invoked by uid 500); 28 Sep 2017 14:55:04 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 8033 invoked by uid 500); 28 Sep 2017 14:55:04 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 8022 invoked by uid 99); 28 Sep 2017 14:55:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 Sep 2017 14:55:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id E4E42D2139; Thu, 28 Sep 2017 14:55:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3 X-Spam-Level: *** X-Spam-Status: No, score=3 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id Ri0D3BP1X3Hv; Thu, 28 Sep 2017 14:55:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 369655F5F7; Thu, 28 Sep 2017 14:55:02 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 0A9BDE0057; Thu, 28 Sep 2017 14:55:00 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id E6FE4C4083D; Thu, 28 Sep 2017 14:54:58 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7671243622173507797==" MIME-Version: 1.0 Subject: Re: Review Request 62381: Removed `docker exec` when performing health checks in docker executor. From: Andrei Budnik To: Lukas Loesche , haosdent huang , Alexander Rukletsov , Andrew Schwartzmeyer , Gaston Kleiman Cc: Andrei Budnik , mesos Date: Thu, 28 Sep 2017 14:54:57 -0000 Message-ID: <20170928145457.40388.41967@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Andrei Budnik X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/62381/ X-Sender: Andrei Budnik References: <20170918172129.56076.85902@reviews-vm2.apache.org> In-Reply-To: <20170918172129.56076.85902@reviews-vm2.apache.org> Reply-To: Andrei Budnik X-ReviewRequest-Repository: mesos --===============7671243622173507797== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62381/#review186559 ----------------------------------------------------------- src/docker/executor.cpp Line 609 (original) `docker exec` is needed for Windows. - Andrei Budnik On Sept. 18, 2017, 5:21 p.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62381/ > ----------------------------------------------------------- > > (Updated Sept. 18, 2017, 5:21 p.m.) > > > Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston Kleiman, haosdent huang, and Lukas Loesche. > > > Bugs: MESOS-4812 > https://issues.apache.org/jira/browse/MESOS-4812 > > > Repository: mesos > > > Description > ------- > > Mesos can enter namespaces via `setns` for launched subprocesses, hence > we got rid of `docker exec` for command health checks. This change > leads to more stable command health checks by making them independent > from docker daemon that might hang. Also, this commit fixes the issue > with incorrect escaping of quote characters in command health checks. > > > Diffs > ----- > > src/docker/executor.cpp e9949f652cd8527991ebfdfbf14e68b4c958fe79 > src/tests/health_check_tests.cpp f4b50b1cb505084f64bf2dd279d9189ca65c8cdc > > > Diff: https://reviews.apache.org/r/62381/diff/2/ > > > Testing > ------- > > internal CI > > > Thanks, > > Andrei Budnik > > --===============7671243622173507797==--