From reviews-return-66273-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Sep 22 19:52:34 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 013F910603 for ; Fri, 22 Sep 2017 19:52:34 +0000 (UTC) Received: (qmail 28321 invoked by uid 500); 22 Sep 2017 19:52:33 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 28288 invoked by uid 500); 22 Sep 2017 19:52:33 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 28277 invoked by uid 99); 22 Sep 2017 19:52:33 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 Sep 2017 19:52:33 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 06B77C4225; Fri, 22 Sep 2017 19:52:33 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3 X-Spam-Level: *** X-Spam-Status: No, score=3 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id jptPguZOvRmE; Fri, 22 Sep 2017 19:52:31 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 680FE5FB2E; Fri, 22 Sep 2017 19:52:31 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id AD464E02C7; Fri, 22 Sep 2017 19:52:30 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 0A108C4016F; Fri, 22 Sep 2017 19:52:29 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6902953559739013588==" MIME-Version: 1.0 Subject: Re: Review Request 62512: Disabled RestartSlaveRequireExecutorAuthentication test on Windows. From: Andrew Schwartzmeyer To: John Kordich , Joseph Wu , Till Toenshoff Cc: Andrew Schwartzmeyer , mesos Date: Fri, 22 Sep 2017 19:52:28 -0000 Message-ID: <20170922195228.9075.41401@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Andrew Schwartzmeyer X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/62512/ X-Sender: Andrew Schwartzmeyer References: <20170922191013.9074.48069@reviews-vm2.apache.org> In-Reply-To: <20170922191013.9074.48069@reviews-vm2.apache.org> Reply-To: Andrew Schwartzmeyer X-ReviewRequest-Repository: mesos --===============6902953559739013588== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62512/ ----------------------------------------------------------- (Updated Sept. 22, 2017, 12:52 p.m.) Review request for mesos, John Kordich, Joseph Wu, and Till Toenshoff. Bugs: MESOS-7992 https://issues.apache.org/jira/browse/MESOS-7992 Repository: mesos Description ------- This test became enabled when building with OpenSSL on Windows. The first part of the test failed because of the use of the Linux command `cat` to launch an indefinitely running task. This was fixed using `more` on Windows. However, the test subsequently fails when recoverying to due "incompatible agent info", an existing bug: MESOS-7604. Diffs ----- src/tests/slave_tests.cpp e9bcfefd52e1e99a7a5877b2e7c30af958ca1723 Diff: https://reviews.apache.org/r/62512/diff/1/ Testing (updated) ------- This represents testing for the whole chain. Built on Windows 10 with OpenSSL 1.0.2L from [Shining Light Productions](https://slproweb.com/products/Win32OpenSSL.html), configuring with `-DENABLE_LIBEVENT=ON -DENABLE_SSL=ON -DOPENSSL_ROOT_DIR="C:\OpenSSL-Win64"`. Ran `stout-tests`, `libprocess-tests`, and `mesos-tests`, all passing except for this disabled one. Verified new SSL tests were enabled. Built on CentOS 7 with CMake `-DENABLE_LIBEVENT=ON -DENABLE_SSL=ON`, all tests passed. ~~Built on CentOS 7 with Autotools, however, I'm running into some seemingly flaky tests.~~ I don't seem to have a reliable Autotools build with SSL at all, even on `master`. Thanks, Andrew Schwartzmeyer --===============6902953559739013588==--