From reviews-return-66236-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Sep 21 20:50:11 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id F38E110C91 for ; Thu, 21 Sep 2017 20:50:10 +0000 (UTC) Received: (qmail 60745 invoked by uid 500); 21 Sep 2017 20:50:10 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 60712 invoked by uid 500); 21 Sep 2017 20:50:10 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 60700 invoked by uid 99); 21 Sep 2017 20:50:10 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 Sep 2017 20:50:10 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 12C51D72A8; Thu, 21 Sep 2017 20:50:10 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.999 X-Spam-Level: ** X-Spam-Status: No, score=2.999 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id O_gxAxb345jk; Thu, 21 Sep 2017 20:50:09 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 0AA395FBDF; Thu, 21 Sep 2017 20:50:09 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id A2EB5E0288; Thu, 21 Sep 2017 20:50:08 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 8FAE9C413CB; Thu, 21 Sep 2017 20:50:08 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1047558951251869798==" MIME-Version: 1.0 Subject: Re: Review Request 62472: Fixed the ordering of Mesos containerizer isolators. From: Mesos Reviewbot Windows To: Jie Yu , Kevin Klues , Benjamin Mahler , Gilbert Song Cc: Mesos Reviewbot Windows , James Peach , mesos Date: Thu, 21 Sep 2017 20:50:08 -0000 Message-ID: <20170921205008.39978.31158@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mesos Reviewbot Windows X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/62472/ X-Sender: Mesos Reviewbot Windows References: <20170921174733.39978.31482@reviews-vm2.apache.org> In-Reply-To: <20170921174733.39978.31482@reviews-vm2.apache.org> Reply-To: Mesos Reviewbot Windows X-ReviewRequest-Repository: mesos --===============1047558951251869798== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62472/#review185923 ----------------------------------------------------------- PASS: Mesos patch 62472 was successfully built and tested. Reviews applied: `['62472']` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62472 - Mesos Reviewbot Windows On Sept. 21, 2017, 7:47 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62472/ > ----------------------------------------------------------- > > (Updated Sept. 21, 2017, 7:47 p.m.) > > > Review request for mesos, Benjamin Mahler, Gilbert Song, Jie Yu, and Kevin Klues. > > > Bugs: MESOS-7643 > https://issues.apache.org/jira/browse/MESOS-7643 > > > Repository: mesos > > > Description > ------- > > Historically, isolators were invoked in the order listed by > the operator in the `--isolation` flag. This changed to an > internal ordering in 6fb9c024, back to the operator ordering > in af474a6fa, and then to an undefined ordering in 9642d3c67b. > > This commit switches back to an internal ordering for all the built-in > isolators. Custom isolators loaded in modules are run in operator order > after all the built-in ones. The rationale for an internal ordering is > expressed in MESOS-5581; basically we should not burden the operator > with having to figure out how to make the order correct. In the case of > custom isolators there's no way for us to know the correct ordering so > we make an arbitrary choice. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.cpp 4d5dc13f363f5d8886983d7dd06a5cecc177c345 > > > Diff: https://reviews.apache.org/r/62472/diff/1/ > > > Testing > ------- > > make check (Fedora 26) > > Posting this as an RFC. If reviewers are OK with the approach, I'll float it on users@ and dev@ and update the documentation. > > > Thanks, > > James Peach > > --===============1047558951251869798==--