From reviews-return-66156-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Sep 20 14:24:45 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6BA3D1070A for ; Wed, 20 Sep 2017 14:24:45 +0000 (UTC) Received: (qmail 17269 invoked by uid 500); 20 Sep 2017 14:24:45 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 17232 invoked by uid 500); 20 Sep 2017 14:24:45 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 17175 invoked by uid 99); 20 Sep 2017 14:24:44 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 Sep 2017 14:24:44 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 77688C4E72; Wed, 20 Sep 2017 14:24:44 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.999 X-Spam-Level: ** X-Spam-Status: No, score=2.999 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id HAW5UMFsou2H; Wed, 20 Sep 2017 14:24:43 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 206BC5F640; Wed, 20 Sep 2017 14:24:43 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 78CEDE00A3; Wed, 20 Sep 2017 14:24:42 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 64B43C401D5; Wed, 20 Sep 2017 14:24:42 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6513410446792869611==" MIME-Version: 1.0 Subject: Review Request 62438: Ignored redundant agent resources updates in master. From: Benjamin Bannier To: Jie Yu , Jan Schlicht Cc: Benjamin Bannier , mesos Date: Wed, 20 Sep 2017 14:24:42 -0000 Message-ID: <20170920142442.1946.48729@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Benjamin Bannier X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/62438/ X-Sender: Benjamin Bannier Reply-To: Benjamin Bannier X-ReviewRequest-Repository: mesos --===============6513410446792869611== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62438/ ----------------------------------------------------------- Review request for mesos, Jie Yu and Jan Schlicht. Repository: mesos Description ------- In the future, agents will send updates on their total, e.g., when resource providers are added or removed. As an update to the agent's total resources currently triggers rescinding of all offered agent resources, spurious updates can negatively affect in-flight offer operations. This patch changes the master so that updates introducing no changes (i.e., the new resources are identical to the old resources) are dropped and do not trigger rescinding of offers anymore. We also adjust the handling of oversubscribed agent resources to drop redundant updates. Diffs ----- src/master/master.cpp 6d84a26bff970b842b58dfb69dbf232ba5c16a20 Diff: https://reviews.apache.org/r/62438/diff/1/ Testing ------- Tested on a number of platforms on internal CI. Thanks, Benjamin Bannier --===============6513410446792869611==--