From reviews-return-66117-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Sep 19 16:53:50 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 09B6410F27 for ; Tue, 19 Sep 2017 16:53:50 +0000 (UTC) Received: (qmail 99740 invoked by uid 500); 19 Sep 2017 16:53:49 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 99711 invoked by uid 500); 19 Sep 2017 16:53:49 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 99700 invoked by uid 99); 19 Sep 2017 16:53:49 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 Sep 2017 16:53:49 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 1E6D31A5892; Tue, 19 Sep 2017 16:53:49 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.25 X-Spam-Level: *** X-Spam-Status: No, score=3.25 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RP_MATCHES_RCVD=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id bNdkDURhmQNq; Tue, 19 Sep 2017 16:53:47 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id D2A5B610E0; Tue, 19 Sep 2017 16:53:46 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 9D75BE0BD0; Tue, 19 Sep 2017 16:53:46 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 8AA40C40961; Tue, 19 Sep 2017 16:53:46 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2405505762890097022==" MIME-Version: 1.0 Subject: Re: Review Request 61528: Implemented a registrar for resource provider manager state. From: Benjamin Bannier To: Jie Yu , Jan Schlicht Cc: Benjamin Bannier , mesos Date: Tue, 19 Sep 2017 16:53:46 -0000 Message-ID: <20170919165346.19954.32113@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Benjamin Bannier X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/61528/ X-Sender: Benjamin Bannier References: <20170915131629.38032.42317@reviews-vm2.apache.org> In-Reply-To: <20170915131629.38032.42317@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: src/resource_provider/registry.proto X-ReviewBoard-Diff-For: src/resource_provider/registrar.cpp X-ReviewBoard-Diff-For: src/resource_provider/registrar.hpp X-ReviewBoard-Diff-For: src/resource_provider/registry.hpp Reply-To: Benjamin Bannier X-ReviewRequest-Repository: mesos --===============2405505762890097022== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61528/ ----------------------------------------------------------- (Updated Sept. 19, 2017, 6:53 p.m.) Review request for mesos, Jie Yu and Jan Schlicht. Changes ------- Addressed Jie's comments. Bugs: MESOS-7555 https://issues.apache.org/jira/browse/MESOS-7555 Repository: mesos Description ------- This patch adds a registry and registrar interface for resource provider managers. The registrar interface is modelled after the master registrar and supports similar operations. Currently a single, LevelDB-backed registrar is implemented which we plan to use for resource provider managers in agents. Current the registry allows to add and remove resource provider IDs. Diffs (updated) ----- src/CMakeLists.txt 1a828c4351ded36f51ccbbe67147da2f50b9cdb1 src/Makefile.am 93ed2bf55447e3e470d9bea8a0b61ce78aad1900 src/resource_provider/registrar.hpp PRE-CREATION src/resource_provider/registrar.cpp PRE-CREATION src/resource_provider/registry.hpp PRE-CREATION src/resource_provider/registry.proto PRE-CREATION src/slave/paths.hpp 51b481fc0870f1e95448f85ee2fd485fceea1919 src/slave/paths.cpp 08177bcef63b998f691be6893ab35891098a2886 src/tests/resource_provider_manager_tests.cpp 3bc56b51526e9dd188423f7349e74246c3295c77 Diff: https://reviews.apache.org/r/61528/diff/6/ Changes: https://reviews.apache.org/r/61528/diff/5-6/ Testing ------- `make check` Thanks, Benjamin Bannier --===============2405505762890097022==--