From reviews-return-66114-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Sep 19 16:53:47 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4F72A10F23 for ; Tue, 19 Sep 2017 16:53:47 +0000 (UTC) Received: (qmail 99286 invoked by uid 500); 19 Sep 2017 16:53:47 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 99254 invoked by uid 500); 19 Sep 2017 16:53:47 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 99218 invoked by uid 99); 19 Sep 2017 16:53:46 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 Sep 2017 16:53:46 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 7E3C4CF4CA; Tue, 19 Sep 2017 16:53:46 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.249 X-Spam-Level: *** X-Spam-Status: No, score=3.249 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id ZDhGsJn3nXyd; Tue, 19 Sep 2017 16:53:45 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 3597C5F640; Tue, 19 Sep 2017 16:53:45 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 89719E0044; Tue, 19 Sep 2017 16:53:44 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 1A9D1C40961; Tue, 19 Sep 2017 16:53:43 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2814869497904848526==" MIME-Version: 1.0 Subject: Re: Review Request 58048: Added 'id' and 'metadata' fields to 'Resource.DiskInfo.Source'. From: Benjamin Bannier To: Jie Yu , Jan Schlicht Cc: Benjamin Bannier , Qian Zhang , mesos Date: Tue, 19 Sep 2017 16:53:43 -0000 Message-ID: <20170919165343.19919.39626@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Benjamin Bannier X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/58048/ X-Sender: Benjamin Bannier References: <20170913152324.50238.49949@reviews-vm2.apache.org> In-Reply-To: <20170913152324.50238.49949@reviews-vm2.apache.org> Reply-To: Benjamin Bannier X-ReviewRequest-Repository: mesos --===============2814869497904848526== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58048/ ----------------------------------------------------------- (Updated Sept. 19, 2017, 6:53 p.m.) Review request for mesos, Jie Yu and Jan Schlicht. Changes ------- Used parameterized test as suggested by Jie. Bugs: MESOS-7312 https://issues.apache.org/jira/browse/MESOS-7312 Repository: mesos Description ------- Ids will allow to create distinguishable resources, e.g., of RAW or BLOCK type. We also add a metadata field which can be used to expose additional disk information. Diffs (updated) ----- include/mesos/mesos.proto fa475dcc3aa0b15ee4b2b740a24ab3c0b9a3274c include/mesos/v1/mesos.proto dfba4181203e23f7eedf67c19379d031e0993fd5 src/common/resources.cpp 14b600ca1577be4910164396c75b866b53439ade src/tests/resources_tests.cpp 8a86efe60024d9e36294f0acb3f43bdd3f52f5bc src/v1/resources.cpp a5cc15591b7611274148139c43465adae44c1dbb Diff: https://reviews.apache.org/r/58048/diff/7/ Changes: https://reviews.apache.org/r/58048/diff/6-7/ Testing ------- make check (OS X, Fedora25) Thanks, Benjamin Bannier --===============2814869497904848526==--