From reviews-return-66113-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Sep 19 16:30:06 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4B8D710E02 for ; Tue, 19 Sep 2017 16:30:06 +0000 (UTC) Received: (qmail 42377 invoked by uid 500); 19 Sep 2017 16:30:06 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 42350 invoked by uid 500); 19 Sep 2017 16:30:06 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 42338 invoked by uid 99); 19 Sep 2017 16:30:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 Sep 2017 16:30:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 75BBBCF30F; Tue, 19 Sep 2017 16:30:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3 X-Spam-Level: *** X-Spam-Status: No, score=3 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id d1dhReUjkQbf; Tue, 19 Sep 2017 16:30:04 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id F158360D8B; Tue, 19 Sep 2017 16:30:03 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 53FC3E00A3; Tue, 19 Sep 2017 16:30:03 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 988BDC40961; Tue, 19 Sep 2017 16:30:02 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0808533714557121126==" MIME-Version: 1.0 Subject: Re: Review Request 62176: Added cmake dependency check for libsasl2 on non-Windows platforms. From: Mesos Reviewbot To: Greg Mann , Jeff Coffler , Joseph Wu , Andrew Schwartzmeyer , Till Toenshoff Cc: Mesos Reviewbot , John Kordich , mesos Date: Tue, 19 Sep 2017 16:30:02 -0000 Message-ID: <20170919163002.19954.53213@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mesos Reviewbot X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/62176/ X-Sender: Mesos Reviewbot References: <20170918202452.55959.46775@reviews-vm2.apache.org> In-Reply-To: <20170918202452.55959.46775@reviews-vm2.apache.org> Reply-To: Mesos Reviewbot X-ReviewRequest-Repository: mesos --===============0808533714557121126== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62176/#review185704 ----------------------------------------------------------- Patch looks great! Reviews applied: [62105, 62106, 62176] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Sept. 18, 2017, 8:24 p.m., John Kordich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62176/ > ----------------------------------------------------------- > > (Updated Sept. 18, 2017, 8:24 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Jeff Coffler, Greg Mann, Joseph Wu, and Till Toenshoff. > > > Bugs: MESOS-3110 > https://issues.apache.org/jira/browse/MESOS-3110 > > > Repository: mesos > > > Description > ------- > > Added cmake dependency check for libsasl2 on non-Windows platforms. > > > Diffs > ----- > > 3rdparty/CMakeLists.txt 2a183a4a46bf8bc97455fe02648407ba561b38e7 > > > Diff: https://reviews.apache.org/r/62176/diff/2/ > > > Testing > ------- > > I tested this on my Ubuntu 16.04 system. When the libsasl2 library doesn't exist, it fails the cmake configure/build. I did not test this on any other platform, but this code is in a "if (NOT WIN32)" block and won't affect a Windows build. I'm uncertain if there is much support for other kinds of builds (like Mac OS), but this should be platform independent. > > > Thanks, > > John Kordich > > --===============0808533714557121126==--