From reviews-return-65832-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Sep 8 22:44:57 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8E0DC1AFAB for ; Fri, 8 Sep 2017 22:44:57 +0000 (UTC) Received: (qmail 57062 invoked by uid 500); 8 Sep 2017 22:44:57 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 57046 invoked by uid 500); 8 Sep 2017 22:44:56 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 57030 invoked by uid 99); 8 Sep 2017 22:44:56 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Sep 2017 22:44:56 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id D08781A252B; Fri, 8 Sep 2017 22:44:55 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.999 X-Spam-Level: ** X-Spam-Status: No, score=2.999 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id JOPjwkcg1ctH; Fri, 8 Sep 2017 22:44:54 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 1E3455F5FD; Fri, 8 Sep 2017 22:44:54 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6DB40E00C9; Fri, 8 Sep 2017 22:44:53 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id D40D3C41A8A; Fri, 8 Sep 2017 22:44:52 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4103707979777135399==" MIME-Version: 1.0 Subject: Re: Review Request 62003: Added `network/ports` isolator nested container tests. From: James Peach To: Qian Zhang , Jiang Yan Xu Cc: Mesos Reviewbot , Mesos Reviewbot Windows , James Peach , mesos Date: Fri, 08 Sep 2017 22:44:52 -0000 Message-ID: <20170908224452.9625.15329@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: James Peach X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/62003/ X-Sender: James Peach References: <20170907215758.39549.20162@reviews-vm2.apache.org> In-Reply-To: <20170907215758.39549.20162@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: src/tests/containerizer/ports_isolator_tests.cpp Reply-To: James Peach X-ReviewRequest-Repository: mesos --===============4103707979777135399== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62003/ ----------------------------------------------------------- (Updated Sept. 8, 2017, 10:44 p.m.) Review request for mesos, Qian Zhang and Jiang Yan Xu. Bugs: MESOS-7675 https://issues.apache.org/jira/browse/MESOS-7675 Repository: mesos Description ------- Added `network/ports` isolator nested container tests using the v1 TaskGroups API. This tests that rogue port usage by a nested task is detected both with and without agent recovery, and that a well-behaved task is preserved across agent recovery. Diffs (updated) ----- src/tests/containerizer/ports_isolator_tests.cpp PRE-CREATION src/tests/mesos.hpp 444c75763aea995708db0b17eafee2d22c912554 Diff: https://reviews.apache.org/r/62003/diff/4/ Changes: https://reviews.apache.org/r/62003/diff/3-4/ Testing ------- make check (Fedora 26) Thanks, James Peach --===============4103707979777135399==--