| Vinod Kone |
Re: Review Request 52064: Support for multiple versions of docs. |
Tue, 12 Sep, 18:14 |
| Kapil Arya |
Review Request 62254: Ignored /proc/self/ns/pid_for_children when listing namespaces. |
Tue, 12 Sep, 18:27 |
| Kapil Arya |
Review Request 62253: Ignored cgroups v2 hierarchy when parsing /proc/self/cgroups. |
Tue, 12 Sep, 18:28 |
| Greg Mann |
Re: Review Request 61982: Cleaned up DefaultExecutor tests. |
Tue, 12 Sep, 18:45 |
| Tim Anderegg |
Re: Review Request 52064: Support for multiple versions of docs. |
Tue, 12 Sep, 18:59 |
| Vinod Kone |
Re: Review Request 52064: Support for multiple versions of docs. |
Tue, 12 Sep, 19:01 |
| Gastón Kleiman |
Re: Review Request 62197: Added new overloads for the `createExecutorInfo` test helper method. |
Tue, 12 Sep, 19:47 |
| Gastón Kleiman |
Re: Review Request 62197: Added new overloads for the `createExecutorInfo` test helper method. |
Tue, 12 Sep, 20:00 |
| Chun-Hung Hsiao |
Re: Review Request 62252: Added `process::Executor::execute()`. |
Tue, 12 Sep, 20:12 |
| Chun-Hung Hsiao |
Re: Review Request 62230: Avoid GC pruning events from blocking other processes. |
Tue, 12 Sep, 20:52 |
| Alexander Rukletsov |
Re: Review Request 62254: Ignored /proc/self/ns/pid_for_children when listing namespaces. |
Tue, 12 Sep, 22:39 |
| Alexander Rukletsov |
Re: Review Request 62253: Ignored cgroups v2 hierarchy when parsing /proc/self/cgroups. |
Tue, 12 Sep, 22:39 |
| Greg Mann |
Re: Review Request 62197: Added new overloads for the `createExecutorInfo` test helper method. |
Tue, 12 Sep, 22:47 |
| Gastón Kleiman |
Re: Review Request 62197: Added new overloads for the `createExecutorInfo` test helper method. |
Tue, 12 Sep, 23:49 |
| Mesos Reviewbot Windows |
Re: Review Request 52064: Support for multiple versions of docs. |
Wed, 13 Sep, 00:30 |
| Jie Yu |
Re: Review Request 58048: Added 'id' and 'metadata' fields to 'Resource.DiskInfo.Source'. |
Wed, 13 Sep, 00:34 |
| Mesos Reviewbot Windows |
Re: Review Request 62254: Ignored /proc/self/ns/pid_for_children when listing namespaces. |
Wed, 13 Sep, 00:36 |
| Zhitao Li |
Re: Review Request 62047: Allowed look up latest executor directory by virtual path. |
Wed, 13 Sep, 01:25 |
| Zhitao Li |
Review Request 62263: Add test to browse and read in sandbox virtual path. |
Wed, 13 Sep, 01:25 |
| Mesos Reviewbot Windows |
Re: Review Request 62246: Added workaround for a docker bug in docker build helper. |
Wed, 13 Sep, 03:40 |
| Jie Yu |
Re: Review Request 62237: Fixed a memory leak in composing containerizer. |
Wed, 13 Sep, 04:47 |
| Benjamin Hindman |
Re: Review Request 62252: Added `process::Executor::execute()`. |
Wed, 13 Sep, 05:10 |
| Mesos Reviewbot Windows |
Re: Review Request 62263: Add test to browse and read in sandbox virtual path. |
Wed, 13 Sep, 05:24 |
| Mesos Reviewbot Windows |
Re: Review Request 62230: Avoid GC pruning events from blocking other processes. |
Wed, 13 Sep, 05:24 |
| Mesos Reviewbot Windows |
Re: Review Request 61473: Do not kill non partition aware tasks. |
Wed, 13 Sep, 07:52 |
| Andrei Budnik |
Review Request 62279: Fixed failure of `DefaultExecutorTest.SigkillExecutor` test on windows. |
Wed, 13 Sep, 12:03 |
| Andrei Budnik |
Re: Review Request 62212: Send TASK_STARTING from the built-in executors. [1/2] |
Wed, 13 Sep, 12:09 |
| Mesos Reviewbot Windows |
Re: Review Request 62279: Fixed failure of `DefaultExecutorTest.SigkillExecutor` test on windows. |
Wed, 13 Sep, 14:14 |
| Benno Evers |
Re: Review Request 62212: Send TASK_STARTING from the built-in executors. |
Wed, 13 Sep, 14:52 |
| Chun-Hung Hsiao |
Re: Review Request 62252: Added `process::Executor::execute()`. |
Wed, 13 Sep, 15:02 |
| Benjamin Bannier |
Review Request 62282: Fixed 'operator==' for 'Resource::DiskInfo::Source'. |
Wed, 13 Sep, 15:23 |
| Benjamin Bannier |
Re: Review Request 58048: Added 'id' and 'metadata' fields to 'Resource.DiskInfo.Source'. |
Wed, 13 Sep, 15:23 |
| Alexander Rukletsov |
Re: Review Request 62279: Fixed failure of `DefaultExecutorTest.SigkillExecutor` test on windows. |
Wed, 13 Sep, 15:58 |
| Jie Yu |
Re: Review Request 62282: Fixed 'operator==' for 'Resource::DiskInfo::Source'. |
Wed, 13 Sep, 16:12 |
| Mesos Reviewbot Windows |
Re: Review Request 62213: Fix unit tests that were broken by the additional TASK_STARTING update. |
Wed, 13 Sep, 16:14 |
| Greg Mann |
Re: Review Request 62197: Added new overloads for the `createExecutorInfo` test helper method. |
Wed, 13 Sep, 16:28 |
| Ilya Pronin |
Review Request 62283: Fixed a comment typo. |
Wed, 13 Sep, 16:40 |
| Ilya Pronin |
Review Request 62284: Fixed code style issues. |
Wed, 13 Sep, 16:40 |
| Ilya Pronin |
Review Request 62285: Added tombstone flag to NOP log action. |
Wed, 13 Sep, 16:40 |
| Ilya Pronin |
Review Request 62286: Added recoverMissing log process. |
Wed, 13 Sep, 16:40 |
| Ilya Pronin |
Review Request 62287: Added Log::Reader::catchup() method. |
Wed, 13 Sep, 16:40 |
| Ilya Pronin |
Review Request 62288: Added Log.Reader.catchup() method to Java bindings. |
Wed, 13 Sep, 16:40 |
| Mesos Reviewbot Windows |
Re: Review Request 62279: Fixed failure of `DefaultExecutorTest.SigkillExecutor` test on windows. |
Wed, 13 Sep, 16:48 |
| Andrei Budnik |
Re: Review Request 62212: Send TASK_STARTING from the built-in executors. |
Wed, 13 Sep, 17:29 |
| Chun-Hung Hsiao |
Re: Review Request 62252: Added `process::Executor::execute()`. |
Wed, 13 Sep, 17:34 |
| Andrei Budnik |
Re: Review Request 62246: Added workaround for a docker bug in docker build helper. |
Wed, 13 Sep, 18:01 |
| Mesos Reviewbot Windows |
Re: Review Request 62288: Added Log.Reader.catchup() method to Java bindings. |
Wed, 13 Sep, 18:46 |
| Mesos Reviewbot |
Re: Review Request 62162: Revert usage of `-isystem` flag. |
Wed, 13 Sep, 19:52 |
| Jie Yu |
Review Request 62295: Moved port mapping isolator doc to the isolators folder. |
Wed, 13 Sep, 20:48 |
| Jie Yu |
Review Request 62296: Moved shared filesystem isolator doc to the isolators folder. |
Wed, 13 Sep, 20:48 |
| Jie Yu |
Review Request 62297: Moved pid namespace isolator doc to the isolators folder. |
Wed, 13 Sep, 20:49 |
| Jie Yu |
Review Request 62298: Moved disk du isolator doc to the isolators folder. |
Wed, 13 Sep, 20:49 |
| Jie Yu |
Review Request 62299: Moved xfs disk isolator doc to the isolators folder. |
Wed, 13 Sep, 20:49 |
| Jie Yu |
Review Request 62300: Moved docker runtime isolator doc to the isolators folder. |
Wed, 13 Sep, 20:49 |
| Jie Yu |
Review Request 62301: Moved cgroups net_cls isolator doc to the isolators folder. |
Wed, 13 Sep, 20:50 |
| Mesos Reviewbot Windows |
Re: Review Request 62246: Added workaround for a docker bug in docker build helper. |
Wed, 13 Sep, 20:50 |
| Jie Yu |
Review Request 62302: Moved docker volume isolator doc to the isolators folder. |
Wed, 13 Sep, 20:50 |
| Jie Yu |
Review Request 62303: Moved IPC namespace isolator doc to the isolators folder. |
Wed, 13 Sep, 20:50 |
| Jie Yu |
Review Request 62304: Moved linux capabilities isolator doc to the isolators folder. |
Wed, 13 Sep, 20:51 |
| Jie Yu |
Review Request 62305: Moved posix rlimits isolator doc to the isolators folder. |
Wed, 13 Sep, 20:51 |
| Jie Yu |
Review Request 62306: Added an index in the mesos containerizer doc about isolators. |
Wed, 13 Sep, 20:51 |
| Jie Yu |
Review Request 62307: Added gpu/nvidia isolator to the index. |
Wed, 13 Sep, 20:51 |
| Jie Yu |
Review Request 62308: Added the description for the isolators section. |
Wed, 13 Sep, 20:52 |
| Mesos Reviewbot Windows |
Re: Review Request 62308: Added the description for the isolators section. |
Wed, 13 Sep, 22:50 |
| Jie Yu |
Review Request 62322: Added initial doc for container volumes. |
Thu, 14 Sep, 05:31 |
| Mesos Reviewbot Windows |
Re: Review Request 62322: Added initial doc for container volumes. |
Thu, 14 Sep, 07:49 |
| Armand Grillet |
Re: Review Request 62018: Updated logging::initialize to make flags optional. |
Thu, 14 Sep, 08:34 |
| Armand Grillet |
Re: Review Request 62037: Added logging::initialize to main functions that use glog. |
Thu, 14 Sep, 08:36 |
| Qian Zhang |
Review Request 62326: Always send TASK_KILLED when the task is killed. |
Thu, 14 Sep, 10:43 |
| Qian Zhang |
Review Request 62327: Checked TASK_KILLED in the test `ROOT_INTERNET_CURL_PortMapper`. |
Thu, 14 Sep, 10:45 |
| Mesos Reviewbot Windows |
Re: Review Request 62037: Added logging::initialize to main functions that use glog. |
Thu, 14 Sep, 10:46 |
| Andrei Budnik |
Re: Review Request 62018: Updated logging::initialize to make flags optional. |
Thu, 14 Sep, 11:16 |
| Benno Evers |
Re: Review Request 62162: Revert usage of `-isystem` flag. |
Thu, 14 Sep, 12:52 |
| Armand Grillet |
Review Request 62332: Linted JavaScript files. |
Thu, 14 Sep, 15:29 |
| Armand Grillet |
Review Request 62333: Added class for linters using a virtual environment. |
Thu, 14 Sep, 15:34 |
| Armand Grillet |
Re: Review Request 62214: Added JavaScript linter. |
Thu, 14 Sep, 15:59 |
| Mesos Reviewbot Windows |
Re: Review Request 62322: Added initial doc for container volumes. |
Thu, 14 Sep, 16:23 |
| Mesos Reviewbot Windows |
Re: Review Request 62246: Added workaround for a docker bug in docker build helper. |
Thu, 14 Sep, 16:29 |
| James Peach |
Re: Review Request 62305: Moved posix rlimits isolator doc to the isolators folder. |
Thu, 14 Sep, 17:30 |
| James Peach |
Re: Review Request 62307: Added gpu/nvidia isolator to the index. |
Thu, 14 Sep, 17:35 |
| Chun-Hung Hsiao |
Review Request 62336: Kicked in disk monitoring early during recovery. |
Thu, 14 Sep, 17:46 |
| Mesos Reviewbot Windows |
Re: Review Request 62327: Checked TASK_KILLED in the test `ROOT_INTERNET_CURL_PortMapper`. |
Thu, 14 Sep, 18:11 |
| Chun-Hung Hsiao |
Re: Review Request 62336: [WIP] Kicked in disk monitoring early during recovery. |
Thu, 14 Sep, 19:17 |
| Mesos Reviewbot Windows |
Re: Review Request 62246: Added workaround for a docker bug in docker build helper. |
Thu, 14 Sep, 19:55 |
| Mesos Reviewbot Windows |
Re: Review Request 62214: Added JavaScript linter. |
Thu, 14 Sep, 21:40 |
| Mesos Reviewbot Windows |
Re: Review Request 62336: [WIP] Kicked in disk monitoring early during recovery. |
Thu, 14 Sep, 23:44 |
| James Peach |
Re: Review Request 62322: Added initial doc for container volumes. |
Fri, 15 Sep, 00:05 |
| James Peach |
Re: Review Request 62308: Added the description for the isolators section. |
Fri, 15 Sep, 00:05 |
| James Peach |
Re: Review Request 62306: Added an index in the mesos containerizer doc about isolators. |
Fri, 15 Sep, 00:05 |
| James Peach |
Re: Review Request 62302: Moved docker volume isolator doc to the isolators folder. |
Fri, 15 Sep, 00:09 |
| James Peach |
Re: Review Request 62301: Moved cgroups net_cls isolator doc to the isolators folder. |
Fri, 15 Sep, 00:09 |
| James Peach |
Re: Review Request 62300: Moved docker runtime isolator doc to the isolators folder. |
Fri, 15 Sep, 00:09 |
| James Peach |
Re: Review Request 62299: Moved xfs disk isolator doc to the isolators folder. |
Fri, 15 Sep, 00:10 |
| James Peach |
Re: Review Request 62298: Moved disk du isolator doc to the isolators folder. |
Fri, 15 Sep, 00:11 |
| James Peach |
Re: Review Request 62297: Moved pid namespace isolator doc to the isolators folder. |
Fri, 15 Sep, 00:14 |
| Benjamin Hindman |
Re: Review Request 62252: Added `process::Executor::execute()`. |
Fri, 15 Sep, 00:36 |
| Chun-Hung Hsiao |
Review Request 62343: Made `GarbageCollector::prune` return a `Future`. |
Fri, 15 Sep, 01:55 |
| Chun-Hung Hsiao |
Review Request 62344: Made `Slave::checkDiskUsage` return a `Future`. |
Fri, 15 Sep, 01:56 |
| Chun-Hung Hsiao |
Re: Review Request 62336: Kicked in disk monitoring early during recovery. |
Fri, 15 Sep, 02:00 |
| Chun-Hung Hsiao |
Re: Review Request 62252: Added `process::Executor::execute()`. |
Fri, 15 Sep, 03:17 |