| Benjamin Bannier |
Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates. |
Thu, 07 Sep, 22:39 |
| Mesos Reviewbot Windows |
Re: Review Request 62047: Allowed look up latest executor directory by virtual path. |
Thu, 07 Sep, 23:15 |
| Andrew Schwartzmeyer |
Re: Review Request 62106: Enabled CRAM MD5 Authentication on Windows and associated tests. |
Thu, 07 Sep, 23:17 |
| Andrew Schwartzmeyer |
Re: Review Request 62105: Enabled building of the Cyrus SASL CRAM MD5 lib on Windows. |
Thu, 07 Sep, 23:24 |
| Andrew Schwartzmeyer |
Re: Review Request 62176: Added cmake dependency check for libsasl2 on non-Windows platforms. |
Thu, 07 Sep, 23:25 |
| Mesos Reviewbot Windows |
Re: Review Request 62003: Added `network/ports` isolator nested container tests. |
Thu, 07 Sep, 23:31 |
| James Peach |
Re: Review Request 60496: Added socket checking to the network ports isolator. |
Fri, 08 Sep, 00:09 |
| Mesos Reviewbot Windows |
Re: Review Request 62176: Added cmake dependency check for libsasl2 on non-Windows platforms. |
Fri, 08 Sep, 00:09 |
| James Peach |
Re: Review Request 60496: Added socket checking to the network ports isolator. |
Fri, 08 Sep, 00:09 |
| James Peach |
Re: Review Request 60496: Added socket checking to the network ports isolator. |
Fri, 08 Sep, 00:10 |
| Mesos Reviewbot Windows |
Re: Review Request 62003: Added `network/ports` isolator nested container tests. |
Fri, 08 Sep, 00:31 |
| Benjamin Mahler |
Re: Review Request 62174: Replace name with virtualPath in files API. |
Fri, 08 Sep, 01:57 |
| Benjamin Mahler |
Re: Review Request 62040: Also log attached virtual path in agent. |
Fri, 08 Sep, 02:04 |
| Benjamin Mahler |
Re: Review Request 62047: Allowed look up latest executor directory by virtual path. |
Fri, 08 Sep, 02:33 |
| Benjamin Mahler |
Re: Review Request 62147: Added a comment about master sending a checkpointed resources message. |
Fri, 08 Sep, 02:56 |
| Mesos Reviewbot |
Re: Review Request 61947: Implemented handling of resource provider offer operations. |
Fri, 08 Sep, 03:05 |
| Qian Zhang |
Re: Review Request 60495: Added network ports isolator listen socket utilities. |
Fri, 08 Sep, 07:43 |
| Qian Zhang |
Re: Review Request 61536: Added network ports isolator socket utilities tests. |
Fri, 08 Sep, 07:56 |
| Qian Zhang |
Re: Review Request 60496: Added socket checking to the network ports isolator. |
Fri, 08 Sep, 09:00 |
| Qian Zhang |
Re: Review Request 60593: Added `network/ports` isolator recovery tests. |
Fri, 08 Sep, 09:10 |
| Jan Schlicht |
Re: Review Request 62147: Added a comment about master sending a checkpointed resources message. |
Fri, 08 Sep, 11:00 |
| Andrei Budnik |
Re: Review Request 62037: Added logging::initialize to main functions that use glog. |
Fri, 08 Sep, 12:14 |
| Andrei Budnik |
Re: Review Request 62018: Updated logging::initialize to make flags optional. |
Fri, 08 Sep, 12:30 |
| Andrei Budnik |
Review Request 62187: This patch is needed to triger Apache CI build. |
Fri, 08 Sep, 15:52 |
| Mesos Reviewbot Windows |
Re: Review Request 62187: This patch is needed to triger Apache CI build. |
Fri, 08 Sep, 18:40 |
| Greg Mann |
Re: Review Request 61982: Cleaned up DefaultExecutor tests. |
Fri, 08 Sep, 18:54 |
| Greg Mann |
Re: Review Request 62042: Change `EXPECT` to `ASSERT` when relying on the assertion afterwards. |
Fri, 08 Sep, 21:01 |
| Greg Mann |
Re: Review Request 62042: Change `EXPECT` to `ASSERT` when relying on the assertion afterwards. |
Fri, 08 Sep, 21:22 |
| John Kordich via Review Board |
Re: Review Request 62105: Enabled building of the Cyrus SASL CRAM MD5 lib on Windows. |
Fri, 08 Sep, 22:13 |
| John Kordich via Review Board |
Re: Review Request 62106: Enabled CRAM MD5 Authentication on Windows and associated tests. |
Fri, 08 Sep, 22:13 |
| John Kordich via Review Board |
Re: Review Request 62176: Added cmake dependency check for libsasl2 on non-Windows platforms. |
Fri, 08 Sep, 22:35 |
| James Peach |
Re: Review Request 61536: Added network ports isolator socket utilities tests. |
Fri, 08 Sep, 22:42 |
| James Peach |
Re: Review Request 62003: Added `network/ports` isolator nested container tests. |
Fri, 08 Sep, 22:44 |
| Greg Mann |
Review Request 62196: Updated the HTTP executor authentication docs. |
Fri, 08 Sep, 22:48 |
| James Peach |
Re: Review Request 62196: Updated the HTTP executor authentication docs. |
Fri, 08 Sep, 22:49 |
| Gastón Kleiman |
Review Request 62197: Added new overloads for the `createExecutorInfo` test helper method. |
Fri, 08 Sep, 22:52 |
| Mesos Reviewbot Windows |
Re: Review Request 62003: Added `network/ports` isolator nested container tests. |
Fri, 08 Sep, 23:11 |
| Mesos Reviewbot Windows |
Re: Review Request 62176: Added cmake dependency check for libsasl2 on non-Windows platforms. |
Fri, 08 Sep, 23:40 |
| Mesos Reviewbot Windows |
Re: Review Request 62197: Added new overloads for the `createExecutorInfo` test helper method. |
Fri, 08 Sep, 23:40 |
| James Peach |
Re: Review Request 61109: Used the default value when parsing an optional enum field. |
Fri, 08 Sep, 23:59 |
| James Peach |
Re: Review Request 61174: Added a test `ProtobufTest.ParseJSONOptionalEnum`. |
Sat, 09 Sep, 00:00 |
| Gastón Kleiman |
Re: Review Request 62197: Added new overloads for the `createExecutorInfo` test helper method. |
Sat, 09 Sep, 00:03 |
| Gastón Kleiman |
Re: Review Request 61982: Cleaned up DefaultExecutor tests. |
Sat, 09 Sep, 00:03 |
| Gastón Kleiman |
Re: Review Request 62042: Changed `EXPECT` to `ASSERT` when relying on the assertion afterwards. |
Sat, 09 Sep, 00:03 |
| Benjamin Mahler |
Re: Review Request 61109: Used the default value when parsing an optional enum field. |
Sat, 09 Sep, 00:53 |
| Mesos Reviewbot Windows |
Re: Review Request 62042: Changed `EXPECT` to `ASSERT` when relying on the assertion afterwards. |
Sat, 09 Sep, 01:44 |
| Benjamin Hindman |
Review Request 62203: Use a `process::Executor` to ensure safety of asynchronous callbacks. |
Sat, 09 Sep, 05:40 |
| Gastón Kleiman |
Re: Review Request 62197: Added new overloads for the `createExecutorInfo` test helper method. |
Sat, 09 Sep, 06:52 |
| Mesos Reviewbot Windows |
Re: Review Request 62203: Use a `process::Executor` to ensure safety of asynchronous callbacks. |
Sat, 09 Sep, 07:44 |
| Qian Zhang |
Re: Review Request 61109: Used the default value when parsing an optional enum field. |
Sun, 10 Sep, 14:48 |
| Mesos Reviewbot |
Re: Review Request 62047: Allowed look up latest executor directory by virtual path. |
Sun, 10 Sep, 22:28 |
| Benno Evers |
Review Request 62212: Send TASK_STARTING from the built-in executors. [1/2] |
Mon, 11 Sep, 09:16 |
| Benno Evers |
Review Request 62213: Send TASK_STARTING from the built-in executors. [2/2] |
Mon, 11 Sep, 09:17 |
| Armand Grillet |
Review Request 62214: Added JavaScript linter. |
Mon, 11 Sep, 09:49 |
| Mesos Reviewbot Windows |
Re: Review Request 62213: Send TASK_STARTING from the built-in executors. [2/2] |
Mon, 11 Sep, 11:15 |
| Armand Grillet |
Re: Review Request 62018: Updated logging::initialize to make flags optional. |
Mon, 11 Sep, 13:53 |
| Armand Grillet |
Re: Review Request 62037: Added logging::initialize to main functions that use glog. |
Mon, 11 Sep, 14:59 |
| Mesos Reviewbot Windows |
Re: Review Request 62214: Added JavaScript linter. |
Mon, 11 Sep, 15:07 |
| Mesos Reviewbot |
Re: Review Request 62187: This patch is needed to triger Apache CI build. |
Mon, 11 Sep, 16:29 |
| James Peach |
Re: Review Request 60495: Added network ports isolator listen socket utilities. |
Mon, 11 Sep, 17:03 |
| James Peach |
Re: Review Request 62003: Added `network/ports` isolator nested container tests. |
Mon, 11 Sep, 19:14 |
| Benjamin Mahler |
Re: Review Request 62214: Added JavaScript linter. |
Mon, 11 Sep, 19:18 |
| Megha Sharma |
Re: Review Request 61473: Do not kill non partition aware tasks. |
Mon, 11 Sep, 21:23 |
| Megha Sharma |
Re: Review Request 61473: Do not kill non partition aware tasks. |
Mon, 11 Sep, 21:24 |
| Chun-Hung Hsiao |
Review Request 62230: Avoid GC pruning events from blocking other processes. |
Mon, 11 Sep, 21:39 |
| Mesos Reviewbot Windows |
Re: Review Request 62037: Added logging::initialize to main functions that use glog. |
Mon, 11 Sep, 22:11 |
| Jiang Yan Xu |
Re: Review Request 62230: Avoid GC pruning events from blocking other processes. |
Mon, 11 Sep, 22:12 |
| Zhitao Li |
Re: Review Request 62040: Also log attached virtual path in agent. |
Mon, 11 Sep, 23:16 |
| Zhitao Li |
Re: Review Request 62047: Allowed look up latest executor directory by virtual path. |
Mon, 11 Sep, 23:17 |
| Zhitao Li |
Re: Review Request 62047: Allowed look up latest executor directory by virtual path. |
Mon, 11 Sep, 23:18 |
| James Peach |
Re: Review Request 62003: Added `network/ports` isolator nested container tests. |
Mon, 11 Sep, 23:33 |
| Chun-Hung Hsiao |
Re: Review Request 62230: Avoid GC pruning events from blocking other processes. |
Tue, 12 Sep, 02:37 |
| Qian Zhang |
Review Request 62237: Fixed a memory leak in composing containerizer. |
Tue, 12 Sep, 07:27 |
| Qian Zhang |
Re: Review Request 60495: Added network ports isolator listen socket utilities. |
Tue, 12 Sep, 08:27 |
| Armand Grillet |
Re: Review Request 62018: Updated logging::initialize to make flags optional. |
Tue, 12 Sep, 08:57 |
| Mesos Reviewbot Windows |
Re: Review Request 62047: Allowed look up latest executor directory by virtual path. |
Tue, 12 Sep, 09:56 |
| Benno Evers |
Re: Review Request 62213: Fix unit tests that were broken by the additional TASK_STARTING update. |
Tue, 12 Sep, 09:58 |
| Mesos Reviewbot Windows |
Re: Review Request 62237: Fixed a memory leak in composing containerizer. |
Tue, 12 Sep, 10:14 |
| Andrei Budnik |
Re: Review Request 62212: Send TASK_STARTING from the built-in executors. [1/2] |
Tue, 12 Sep, 11:03 |
| Alexander Rukletsov |
Re: Review Request 62212: Send TASK_STARTING from the built-in executors. [1/2] |
Tue, 12 Sep, 11:07 |
| Alexander Rukletsov |
Re: Review Request 62212: Send TASK_STARTING from the built-in executors. [1/2] |
Tue, 12 Sep, 11:11 |
| Armand Grillet |
Re: Review Request 62018: Updated logging::initialize to make flags optional. |
Tue, 12 Sep, 11:33 |
| Benno Evers |
Re: Review Request 62212: Send TASK_STARTING from the built-in executors. [1/2] |
Tue, 12 Sep, 11:44 |
| Benno Evers |
Re: Review Request 62212: Send TASK_STARTING from the built-in executors. [1/2] |
Tue, 12 Sep, 11:45 |
| Ilya Pronin |
Review Request 62240: Removed metrics removal from Master::failoverFramework(). |
Tue, 12 Sep, 12:59 |
| Ilya Pronin |
Review Request 62241: Added SchedulerHttpApiTest.UpdateHttpToPidSchedulerAndBack test. |
Tue, 12 Sep, 12:59 |
| Benjamin Bannier |
Re: Review Request 58048: Added 'id' and 'metadata' fields to 'Resource.DiskInfo.Source'. |
Tue, 12 Sep, 13:14 |
| Benjamin Bannier |
Re: Review Request 58048: Added 'id' and 'metadata' fields to 'Resource.DiskInfo.Source'. |
Tue, 12 Sep, 13:14 |
| Benjamin Bannier |
Re: Review Request 58048: Added 'id' and 'metadata' fields to 'Resource.DiskInfo.Source'. |
Tue, 12 Sep, 13:14 |
| Benjamin Bannier |
Re: Review Request 58048: Added 'id' and 'metadata' fields to 'Resource.DiskInfo.Source'. |
Tue, 12 Sep, 13:14 |
| Benjamin Bannier |
Re: Review Request 58048: Added 'id' and 'metadata' fields to 'Resource.DiskInfo.Source'. |
Tue, 12 Sep, 13:14 |
| Mesos Reviewbot Windows |
Re: Review Request 62230: Avoid GC pruning events from blocking other processes. |
Tue, 12 Sep, 14:13 |
| Mesos Reviewbot Windows |
Re: Review Request 62213: Fix unit tests that were broken by the additional TASK_STARTING update. |
Tue, 12 Sep, 14:15 |
| Mesos Reviewbot Windows |
Re: Review Request 62241: Added SchedulerHttpApiTest.UpdateHttpToPidSchedulerAndBack test. |
Tue, 12 Sep, 14:16 |
| Ilya Pronin |
Re: Review Request 62241: Added SchedulerHttpApiTest.UpdateHttpToPidSchedulerAndBack test. |
Tue, 12 Sep, 14:20 |
| Andrei Budnik |
Review Request 62246: Added workaround for a docker bug in docker build helper. |
Tue, 12 Sep, 14:33 |
| Mesos Reviewbot Windows |
Re: Review Request 62246: Added workaround for a docker bug in docker build helper. |
Tue, 12 Sep, 15:59 |
| Greg Mann |
Re: Review Request 62197: Added new overloads for the `createExecutorInfo` test helper method. |
Tue, 12 Sep, 17:21 |
| Mesos Reviewbot |
Re: Review Request 62042: Changed `EXPECT` to `ASSERT` when relying on the assertion afterwards. |
Tue, 12 Sep, 17:22 |
| Chun-Hung Hsiao |
Review Request 62252: Added `process::Executor::execute()`. |
Tue, 12 Sep, 18:12 |