| Armand Grillet |
Review Request 62122: Fixed parameter name in uri/fetcher.hpp. |
Wed, 06 Sep, 14:43 |
| Benjamin Bannier |
Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates. |
Wed, 06 Sep, 14:52 |
| Benno Evers |
Review Request 62123: Send additional TASK_STARTING update from built-in executors. |
Wed, 06 Sep, 14:58 |
| Mesos Reviewbot |
Re: Review Request 62113: Fixed compilation issue on Mac OS. |
Wed, 06 Sep, 14:59 |
| James Peach |
Re: Review Request 62003: Added `network/ports` isolator nested container tests. |
Wed, 06 Sep, 16:04 |
| Jie Yu |
Re: Review Request 62113: Fixed compilation issue on Mac OS. |
Wed, 06 Sep, 16:06 |
| Joseph Wu |
Re: Review Request 62116: Excluded invalid offers from abnormal termination metrics. |
Wed, 06 Sep, 16:51 |
| Mesos Reviewbot Windows |
Re: Review Request 62122: Fixed parameter name in uri/fetcher.hpp. |
Wed, 06 Sep, 17:05 |
| Jie Yu |
Re: Review Request 58048: Added id to Resource.DiskInfo. |
Wed, 06 Sep, 17:15 |
| John Kordich via Review Board |
Re: Review Request 62105: Enabled building of the Cyrus SASL CRAM MD5 lib on Windows. |
Wed, 06 Sep, 19:07 |
| Joseph Wu |
Re: Review Request 62105: Enabled building of the Cyrus SASL CRAM MD5 lib on Windows. |
Wed, 06 Sep, 19:25 |
| Mesos Reviewbot |
Re: Review Request 62115: Fix stout build with newer boost versions. |
Wed, 06 Sep, 20:08 |
| Chun-Hung Hsiao |
Re: Review Request 62116: Excluded invalid offers from abnormal termination metrics. |
Wed, 06 Sep, 20:10 |
| Andrew Schwartzmeyer |
Re: Review Request 62113: Fixed compilation issue on Mac OS. |
Wed, 06 Sep, 20:15 |
| Andrew Schwartzmeyer |
Re: Review Request 62070: Added protobufs to CMake project to facilitate indexing. |
Wed, 06 Sep, 20:19 |
| Andrew Schwartzmeyer |
Re: Review Request 62071: Added non-src files to CMake project to facilitate indexing. |
Wed, 06 Sep, 20:23 |
| John Kordich via Review Board |
Re: Review Request 62105: Enabled building of the Cyrus SASL CRAM MD5 lib on Windows. |
Wed, 06 Sep, 20:35 |
| John Kordich via Review Board |
Re: Review Request 62106: Enabled CRAM MD5 Authentication on Windows and associated tests. |
Wed, 06 Sep, 20:35 |
| Andrew Schwartzmeyer |
Re: Review Request 62106: Enabled CRAM MD5 Authentication on Windows and associated tests. |
Wed, 06 Sep, 20:42 |
| Andrew Schwartzmeyer |
Re: Review Request 62105: Enabled building of the Cyrus SASL CRAM MD5 lib on Windows. |
Wed, 06 Sep, 20:48 |
| James DeFelice |
Re: Review Request 58021: Added storage-related offer operations. |
Wed, 06 Sep, 20:55 |
| Benjamin Mahler |
Re: Review Request 62040: Also log attached path in agent. |
Wed, 06 Sep, 20:57 |
| Jie Yu |
Re: Review Request 58021: Added storage-related offer operations. |
Wed, 06 Sep, 21:03 |
| Benjamin Mahler |
Re: Review Request 62053: Removed garbage collector. |
Wed, 06 Sep, 21:22 |
| Benjamin Mahler |
Re: Review Request 62047: Allowed look up latest executor directory by virtual path. |
Wed, 06 Sep, 21:28 |
| Jie Yu |
Re: Review Request 61946: Added validation of resource provider operations. |
Wed, 06 Sep, 21:41 |
| Joseph Wu |
Re: Review Request 62105: Enabled building of the Cyrus SASL CRAM MD5 lib on Windows. |
Wed, 06 Sep, 21:42 |
| Jie Yu |
Re: Review Request 61182: Sent a resource provider message when providers subscribe. |
Wed, 06 Sep, 22:23 |
| Chun-Hung Hsiao |
Review Request 62140: Trigger the first disk-usage GC during recovery. |
Wed, 06 Sep, 23:29 |
| Jie Yu |
Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates. |
Wed, 06 Sep, 23:32 |
| Joseph Wu |
Re: Review Request 60890: WIP: Defined API for launching standalone containers. |
Thu, 07 Sep, 00:37 |
| Joseph Wu |
Re: Review Request 60891: WIP: Added ACLs and AuthZ for standalone containers. |
Thu, 07 Sep, 00:38 |
| Joseph Wu |
Review Request 62142: Moved GPU resource validation into common file. |
Thu, 07 Sep, 00:40 |
| Joseph Wu |
Review Request 62143: WIP: Added validation for Standalone Container APIs. |
Thu, 07 Sep, 00:40 |
| Joseph Wu |
Review Request 62144: Added extra constructors for ObjectApprover::Object. |
Thu, 07 Sep, 00:40 |
| Joseph Wu |
Review Request 62145: WIP: Implemented Standalone Container API. |
Thu, 07 Sep, 00:44 |
| John Kordich via Review Board |
Re: Review Request 62105: Enabled building of the Cyrus SASL CRAM MD5 lib on Windows. |
Thu, 07 Sep, 01:11 |
| John Kordich via Review Board |
Re: Review Request 62106: Enabled CRAM MD5 Authentication on Windows and associated tests. |
Thu, 07 Sep, 01:11 |
| John Kordich via Review Board |
Re: Review Request 62105: Enabled building of the Cyrus SASL CRAM MD5 lib on Windows. |
Thu, 07 Sep, 01:14 |
| Andrew Schwartzmeyer |
Re: Review Request 62106: Enabled CRAM MD5 Authentication on Windows and associated tests. |
Thu, 07 Sep, 01:18 |
| Benjamin Mahler |
Re: Review Request 62053: Removed garbage collector. |
Thu, 07 Sep, 01:51 |
| Benjamin Mahler |
Re: Review Request 62053: Removed garbage collector. |
Thu, 07 Sep, 02:15 |
| Qian Zhang |
Re: Review Request 62003: Added `network/ports` isolator nested container tests. |
Thu, 07 Sep, 02:37 |
| Chun-Hung Hsiao |
Re: Review Request 62140: Shorten the default interval between disk-usage GCs. |
Thu, 07 Sep, 04:00 |
| Chun-Hung Hsiao |
Re: Review Request 62140: Shorten the default interval between disk-usage GCs. |
Thu, 07 Sep, 04:01 |
| Avinash sridharan |
Re: Review Request 62017: Allows port mapper plugin to have optional args. |
Thu, 07 Sep, 04:08 |
| Jie Yu |
Review Request 62147: Added a comment about master sending a checkpointed resources message. |
Thu, 07 Sep, 04:11 |
| James Peach |
Re: Review Request 61799: Replaced ABORT with SAFE_EXIT in childhook in `subprocess_posix.hpp`. |
Thu, 07 Sep, 04:55 |
| James Peach |
Re: Review Request 61801: Used SAFE_EXIT macro in `CgroupsAnyHierarchyTest.ROOT_CGROUPS_Write`. |
Thu, 07 Sep, 04:55 |
| James Peach |
Re: Review Request 61800: Enhanced async-signal safety of `signalSafeWriteStatus` function. |
Thu, 07 Sep, 04:58 |
| James Peach |
Re: Review Request 61798: Added SAFE_EXIT as alternative to ABORT. |
Thu, 07 Sep, 04:58 |
| Anand Mazumdar |
Review Request 62148: Made the `stop()` logic in the scheduler library simpler. |
Thu, 07 Sep, 05:54 |
| Anand Mazumdar |
Re: Review Request 62148: Made the `stop()` logic in the scheduler library simpler. |
Thu, 07 Sep, 05:54 |
| Mesos Reviewbot Windows |
Re: Review Request 62106: Enabled CRAM MD5 Authentication on Windows and associated tests. |
Thu, 07 Sep, 10:41 |
| Alexander Rukletsov |
Re: Review Request 61495: Add documentation for possible task reasons. |
Thu, 07 Sep, 11:24 |
| Mesos Reviewbot Windows |
Re: Review Request 62047: Allowed look up latest executor directory by virtual path. |
Thu, 07 Sep, 11:41 |
| Mesos Reviewbot Windows |
Re: Review Request 62145: WIP: Implemented Standalone Container API. |
Thu, 07 Sep, 11:42 |
| Mesos Reviewbot |
Re: Review Request 62122: Fixed parameter name in uri/fetcher.hpp. |
Thu, 07 Sep, 11:46 |
| Alexander Rukletsov |
Re: Review Request 62140: Shorten the default interval between disk-usage GCs. |
Thu, 07 Sep, 12:05 |
| Benno Evers |
Re: Review Request 61558: Move duplicate comment closer to implementation. |
Thu, 07 Sep, 12:06 |
| Jan Schlicht |
Re: Review Request 61947: Implemented handling of resource provider offer operations. |
Thu, 07 Sep, 12:27 |
| Mesos Reviewbot Windows |
Re: Review Request 62148: Made the `stop()` logic in the scheduler library simpler. |
Thu, 07 Sep, 15:01 |
| Benjamin Bannier |
Review Request 62158: Rescinded offers possibly affected by updates to agent total resources. |
Thu, 07 Sep, 15:12 |
| Benjamin Bannier |
Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates. |
Thu, 07 Sep, 15:13 |
| Benjamin Bannier |
Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates. |
Thu, 07 Sep, 15:13 |
| Chun-Hung Hsiao |
Re: Review Request 62140: Shorten the default interval between disk-usage GCs. |
Thu, 07 Sep, 15:16 |
| Benno Evers |
Review Request 62160: Fix stout build with newer boost versions. |
Thu, 07 Sep, 15:21 |
| Benno Evers |
Review Request 62161: Update boost version. |
Thu, 07 Sep, 15:22 |
| Benno Evers |
Review Request 62162: Revert usage of `-isystem` flag. |
Thu, 07 Sep, 15:22 |
| Benjamin Hindman |
Re: Review Request 62148: Made the `stop()` logic in the scheduler library simpler. |
Thu, 07 Sep, 15:33 |
| Anand Mazumdar |
Re: Review Request 62148: Made the `stop()` logic in the scheduler library simpler. |
Thu, 07 Sep, 16:13 |
| Mesos Reviewbot Windows |
Re: Review Request 62162: Revert usage of `-isystem` flag. |
Thu, 07 Sep, 16:30 |
| Mesos Reviewbot Windows |
Re: Review Request 62147: Added a comment about master sending a checkpointed resources message. |
Thu, 07 Sep, 16:30 |
| Mesos Reviewbot Windows |
Re: Review Request 62140: Shorten the default interval between disk-usage GCs. |
Thu, 07 Sep, 16:30 |
| Mesos Reviewbot Windows |
Re: Review Request 61947: Implemented handling of resource provider offer operations. |
Thu, 07 Sep, 17:01 |
| Greg Mann |
Re: Review Request 62042: Change `EXPECT` to `ASSERT` when relying on the assertion afterwards. |
Thu, 07 Sep, 17:45 |
| Kapil Arya |
Review Request 62166: Updated RC tagging+voting mechanism. |
Thu, 07 Sep, 17:57 |
| Mesos Reviewbot Windows |
Re: Review Request 62042: Change `EXPECT` to `ASSERT` when relying on the assertion afterwards. |
Thu, 07 Sep, 18:01 |
| Gastón Kleiman |
Re: Review Request 62042: Change `EXPECT` to `ASSERT` when relying on the assertion afterwards. |
Thu, 07 Sep, 18:09 |
| Jie Yu |
Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates. |
Thu, 07 Sep, 19:10 |
| Jie Yu |
Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates. |
Thu, 07 Sep, 19:13 |
| Jie Yu |
Re: Review Request 60890: WIP: Defined API for launching standalone containers. |
Thu, 07 Sep, 19:38 |
| Mesos Reviewbot Windows |
Re: Review Request 62166: Updated RC tagging+voting mechanism. |
Thu, 07 Sep, 19:42 |
| Mesos Reviewbot Windows |
Re: Review Request 62042: Change `EXPECT` to `ASSERT` when relying on the assertion afterwards. |
Thu, 07 Sep, 20:01 |
| Vinod Kone |
Re: Review Request 62166: Updated RC tagging+voting mechanism. |
Thu, 07 Sep, 20:28 |
| Zhitao Li |
Re: Review Request 62040: Also log attached virtual path in agent. |
Thu, 07 Sep, 21:16 |
| Zhitao Li |
Review Request 62174: Replace name with virtualPath in files API. |
Thu, 07 Sep, 21:16 |
| Zhitao Li |
Re: Review Request 62040: Also log attached virtual path in agent. |
Thu, 07 Sep, 21:17 |
| Zhitao Li |
Re: Review Request 62047: Allowed look up latest executor directory by virtual path. |
Thu, 07 Sep, 21:18 |
| Zhitao Li |
Re: Review Request 62047: Allowed look up latest executor directory by virtual path. |
Thu, 07 Sep, 21:18 |
| James Peach |
Re: Review Request 60492: Added a `network/ports` isolator skeleton. |
Thu, 07 Sep, 21:50 |
| James Peach |
Re: Review Request 60495: Added network ports isolator listen socket utilities. |
Thu, 07 Sep, 21:50 |
| James Peach |
Re: Review Request 60765: Added basic `network/ports` isolator tests. |
Thu, 07 Sep, 21:57 |
| James Peach |
Re: Review Request 60593: Added `network/ports` isolator recovery tests. |
Thu, 07 Sep, 21:57 |
| James Peach |
Re: Review Request 60593: Added `network/ports` isolator recovery tests. |
Thu, 07 Sep, 21:57 |
| James Peach |
Re: Review Request 60593: Added `network/ports` isolator recovery tests. |
Thu, 07 Sep, 21:57 |
| James Peach |
Re: Review Request 62003: Added `network/ports` isolator nested container tests. |
Thu, 07 Sep, 21:57 |
| John Kordich via Review Board |
Review Request 62176: Added cmake dependency check for libsasl2 on non-Windows platforms. |
Thu, 07 Sep, 22:21 |
| Benjamin Bannier |
Re: Review Request 61528: Implemented a registrar for resource provider manager state. |
Thu, 07 Sep, 22:36 |
| Benjamin Bannier |
Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates. |
Thu, 07 Sep, 22:38 |