mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jiang Yan Xu <...@jxu.me>
Subject Re: Review Request 61473: Do not kill non partition aware tasks.
Date Sat, 30 Sep 2017 00:37:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61473/#review186737
-----------------------------------------------------------



As I commented on the JIRA, we should probably bring the work for MESOS-6406 into this JIRA
because this JIRA wouldn't be complete without it. It certainly should be a different patch
though.

For this patch we should also update the comments above `PARTITION_AWARE` API to reflect the
change.
https://github.com/apache/mesos/blob/6eefc685ccf304d0fb8ed4ff9bc314197d77f078/include/mesos/mesos.proto#L336

Also please search the docs for necessary changes.


src/tests/partition_tests.cpp
Line 526 (original), 526 (patched)
<https://reviews.apache.org/r/61473/#comment263536>

    s/still/are still/



src/tests/partition_tests.cpp
Line 708 (original), 708 (patched)
<https://reviews.apache.org/r/61473/#comment263539>

    s/the not PARTITION_AWARE framework/the non-PARTITION_AWARE framework/



src/tests/partition_tests.cpp
Lines 728-729 (original), 728-729 (patched)
<https://reviews.apache.org/r/61473/#comment263540>

    Update comments?



src/tests/partition_tests.cpp
Lines 2045 (patched)
<https://reviews.apache.org/r/61473/#comment263581>

    Perhaps add a comment: `// The agent may resend status updates.`


- Jiang Yan Xu


On Sept. 24, 2017, 3:46 p.m., Megha Sharma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61473/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2017, 3:46 p.m.)
> 
> 
> Review request for mesos, James Peach, Vinod Kone, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-7215
>     https://issues.apache.org/jira/browse/MESOS-7215
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Master will not kill the tasks for non-Partition aware frameworks
> when an unreachable agent re-registers with the master.
> Master used to send a ShutdownFrameworkMessages to the agent
> to kill the tasks from non partition aware frameworks including the
> ones that are still registered which was problematic because the offer
> from this agent could still go to the same framework which could then
> launch new tasks. The agent would then receive tasks of the same
> framework and ignore them because it thinks the framework is shutting
> down. The framework is not shutting down of course, so from the master
> and the scheduler’s perspective the task is pending in STAGING forever
> until the next agent reregistration, which could happen much later.
> This commit fixes the problem by not shutting down the non-partition
> aware frameworks on such an agent.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 28d0393fb5962df4d731521265efd81a54e1e655 
>   src/master/master.hpp 05f88111afb4fa0e2baf57106e1479914c16a113 
>   src/master/master.cpp 6d84a26bff970b842b58dfb69dbf232ba5c16a20 
>   src/tests/partition_tests.cpp 0886f4890ac3fec6f38146946892769a99c3e68f 
> 
> 
> Diff: https://reviews.apache.org/r/61473/diff/7/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Megha Sharma
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message